search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
4.74k stars 147 forks source link

OT SVG support - patches included #629

Open HinTak opened 6 months ago

HinTak commented 6 months ago

Is your feature request related to a problem? Please describe.

Would you considering adding the patches to your fork? https://github.com/HinTak/chromium-mod-CI

Describe the solution you'd like, including relevant patches or source

Patches included.

Additional Notes

See the qt web engine filing also. You have a chance to be better than both chrome, Firefox, and Safari in terms of colour font support.

gz83 commented 6 months ago

First of all, thank you very much for your work. Also, have you tried submitting these patches you wrote to Google for review?

HinTak commented 6 months ago

The last comments in both threads are mine : https://bugs.chromium.org/p/chromium/issues/detail?id=306078 https://issues.chromium.org/40336440 . In addition, I am in some other mailing lists where the relevant google engineers frequent too. Consider the work is mostly done by them and the patches do very little beyond flipping some options, I think their choice is more a strategy against Firefox and Webkit than technical. (As in make it work only as a competitive target to try to do a better(?) alternative).

gz83 commented 6 months ago

Have you verified that the relevant support actually takes effect after applying these patches? In addition, I took a look at the patches you wrote, and there seem to be some inconsistencies in them that do not comply with Google's coding standards.

@HinTak

HinTak commented 6 months ago

Testing and verification are done via https://github.com/HinTak/Qt6WE-OT-SVG . As for coding standard, please feel free to comment further. Yes, it is against m118, slightly older.

gz83 commented 6 months ago

You only need to use the git cl format command after editing the Chromium source code to automatically reformat the code and comply with Google's coding standards. The prerequisite for running the above command is that you need to deploy Chromium's depot_tools.

HinTak commented 6 months ago

Okay, thanks for the tips. I only work with skia in git; chromium against snapshot tar balls. I 'll think about how to do the formatting on github ci.

HinTak commented 6 months ago

I probably should put these two links next to the patches (they are on the minimal web browser script README) - just visit them before and after applying the patches to see the difference: https://pixelambacht.nl/chromacheck/

https://yoksel.github.io/color-fonts-demo/

(Or with a different browser - Firefox/ webkitgtk both handle OT-SVG quite well, but missing COLRv1 and others which chrome supports)

HinTak commented 6 months ago

If you have a git repo handy, can you git cl format then post the result? If it is just white space, I 'll up date the patches.

gz83 commented 6 months ago

We don't need to reformat the code yet, I just gave you a reminder. I saw in your patches that the files that need to be modified involve components such as ots, skia, and blink. Have you discussed it with the developers of ots, skia, and blink before or submitted patches to them?

By the way, due to some potential impacts (security, binary size, W3C specifications, etc.), we should modify the relevant files with caution.

HinTak commented 6 months ago

The relevant people are all CC'ed on those two issue URLs, as well as subscribers of a few mailing lists on which I posted the work. This has been going on for 8 months. If they want to say something, they'd have done so by now.

HinTak commented 6 months ago

The skia part of the patch has gotten into skia-python 6 months ago (and I have been invited as co-maintainer/releases since).