search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
4.44k stars 140 forks source link

Thorium overwrites any Web Data file it did not generate #647

Open awsms opened 2 months ago

awsms commented 2 months ago

System Details

Problem I'm not sure if this should be a feature request or a bug, but Thorium immediatly overwrites the 'Web Default' file which contains various customized options (such as custom search engines). I was able to flawlessly migrate this file between different chromium-based browsers (Chromium, ungoogled-chromium, Brave), but Thorium overwrites it at launch.

Alex313031 commented 2 months ago

@awsms This is probably because of the extra search engines that I added to thorium. As part of that, an integer called "kProfileDataVersion" is set, and this number is always one version ahead of official Chromium, specifically so that people migrating from older Chromium/Thorium versions will get the new search engines, and get the new favicons with the search engines.

awsms commented 2 months ago

@awsms This is probably because of the extra search engines that I added to thorium. As part of that, an integer called "kProfileDataVersion" is set, and this number is always one version ahead of official Chromium, specifically so that people migrating from older Chromium/Thorium versions will get the new search engines, and get the new favicons with the search engines.

That's what I assumed from the README (with the search engine changes), but why not add them to the Web Data file, instead of replacing any not-thorium made file? I wasn't able to find the kProfileDataVersion property, is that in a config file? Or the Web Data sqlite one? A bit lost here :(

edit: if someone is looking to achieve for the same thing as me (ie, transferring the custom search keywords), simply open both Web Data dbs in DB Browser for SQLite, then copy paste the whole keywords table as an SQL statement (only select the short_name, keyword, favicon_url and url attributes), then paste it in the thorium db, then execute the query. I was a bit surprised to find that everything else was properly imported from my ungoogled-chromium profile (history, open tabs, extensions and their settings). Thanks for making thorium!