search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
5.04k stars 153 forks source link

Why is thorium catting $HOME/.local/share/sddm/xorg-session.log? #759

Open littleblack111 opened 3 months ago

littleblack111 commented 3 months ago

System Details

Problem A clear and concise description of what the bug is. Why does it need to cat .local/share/sddm/xorg-session.log

Screenshots If applicable, add screenshots to help explain your problem. Screenshot_2024-08-04-10-50-35_3840x2160 Screenshot_2024-08-04-10-50-28_3840x2160

Additional Notes Add any other context about the problem here. I tried using chromium. it doesnt do this

Alex313031 commented 3 months ago

@littleblack111 I tried recreating this, I could only make it happen on Arch with lightdm and sddm.

GDM, Wayland, and pure X11 (without DE) didn't do this. I really don't know why. I also didn't test on Ubuntu or Debian since I didn't want to go through the hassle of installing and configuring another session manager and/or DE.

Also, when you tested Chromium, was it at the same version as Thorium, and with the same flags enabled/disabled?

When comparing Chromium and Thorium you should always make sure variables that could influence behavior like version, settings, and flags are the same between them.

While the session log doesn't contain any personally identifiable information, it does contain a lot more system info than Chromium is normally afforded, so it shouldn't be catting it unless necessary.

Lastly, can you test with the new M126 version that I just released today >

The only things that I change in Thorium related to xorg are two things: The flag to enable auto-dark mode (which only applies if it is enabled on chrome://flags, and only works properly on systems with GTK3), and then some code to enable tab dragging and dropping between windows when the underlying display stack doesn't support it. (For example, it lets you drag and drop a tab under pure X11 without a WM or DE).

littleblack111 commented 3 months ago

Ur right. I'll try them again later with the same variables(and the latest versions)

Yes I'm using arch with sddm

Alex313031 commented 3 months ago

@littleblack111 I was going to post a link to the M126 version, but the release is delayed till tommorow because I screwed up google sync, so we had to rebuild the releases after a fix.

littleblack111 commented 3 months ago

Alright. Please lmk when u finish. And ya indeed I tried it yesterday and the google sync is broken. I'll try again later(it somehow updated through the aur, although it worked again after I restarted it...)

Alex313031 commented 2 months ago

@littleblack111 How's it going now. Did you test with M126 Chromium to see if same thing? Also, did you try with latest release.

littleblack111 commented 2 months ago

yep. tried. now i swapped to hyprland so uhh.. it changed from xorg-session.log -> [1320670] cat /home/system/.local/share/sddm/wayland-session.log lol

Alex313031 commented 2 months ago

@littleblack111 I am at a loss. Cant find references to those files or even the sddm/gdm directory in the Chromium code search. IDK what else to do lol. I guess you'll have to "trust me bro" (Linus Tech Tips reference lol), that Thorium isn't trying to maliciously get info from system session files.

Also, you might try disabling these flags. They are normally disabled in Chromium but I have enabled them by default for GPU acceleration to work on more hardware configs.

chrome://flags/#vaapi-video-decode-linux-gl chrome://flags/#vaapi-on-nvidia-gpus

littleblack111 commented 2 months ago

lol. sure i guess. u cant rly obtain malicious infomation from log as well so ye. lets just leave this open and see if in the future, anyone gonna find out