search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
5k stars 151 forks source link

The flag called 'Disable Thorium Top Bar Icons' doesn't work properly. #762

Open rakinosine opened 3 months ago

rakinosine commented 3 months ago

System Details

Problem Even after enabling the flag called 'Disable Thorium Top Bar Icons' some of the icons are still colorful which include 'Stop loading this page' icon, Extensions icon, Close icon, Incognito icon and so on.

Screenshots image image image

Thanks in advance.

gz83 commented 3 months ago

This is intentional

ottozumkeller commented 3 months ago

Maybe add an option for the flag to disable it for all icons? Like "Enable", "Disable", "Disable all".

rakinosine commented 3 months ago

This is intentional It looks kind of ugly.

Alex313031 commented 2 months ago

@rakincw @ottozumkeller I wanna make it disable color on ALL of the top bar icons and the icons in the main menu However, secondary icons like incognito and "chevron" icons will be left alone. Its because for each icon I want to add to the flag, I have to make a copy of the icon without color, and then add the source code file that manages that icon and add an "if else" statement for the flag. Doing this for all the icons that thorium modifies would be too much work, so I'm mainly concerned about the prominent ones that people see all the time when using the browser.

Also, specificially about the incognito one, I find it useful because if I have a bunch of windows open and a few incognito windows open, it makes it alot easier to identify on either Windows or Ubuntu because I can toggle "overview" mode and it is easy to distinguish the bright red. Otherwise it is hard to tell which is which without manually cycling through all your Thorium windows. And in my case, I am a browser "hypertasker" (which really just means I'm lazy at closing tabs lolol), so I often have up to 10 or more windows open, so it gets annoying.

shawny43 commented 1 month ago

Why not just redo the design and create an monochrome. Also, remember browser have themes that modify the color of the browser. Some of color you choose could conflict with the rest color of the UI and being unreadable.

Also, for incognito, purple in monet style could be a nice fit, firefox and other browser use purple pallets to define incognito mode.

I recommend you to look at MD3 with the color pallets to know more, since Chromium is based on this model now.
https://m3.material.io/

Also, maybe if you can code better, just get inspiration of Firefox and seperate incognito window from the main openned app. This could be a nice start to determinate which one is real incognito.

There an example with Zen Browser based on Firefox fork. image

image

Yes i have to clean-up my taskbar lol.