search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
5.07k stars 154 forks source link

Instant browser crash when accessing certain sites (like chrome web store) #864

Open pixelpicnic opened 1 month ago

pixelpicnic commented 1 month ago

System Details

Problem Browser crashes during some operations / accessing some sites. It seems I had some tab open that when loaded, crashed the browser. I closed all tabs, cleared cache, and tried again. I was able to reproduce the crash reliably when accessing the chrome web store, So maybe google rolled something out that breaks this build?

Cache cleared (all time), extensions disabled, cold booted

Steps to Recreate:

ika-musuko commented 1 month ago

I think I might be running into the same issue as well and have similar specs to the OP. After a few minutes of browsing, Thorium just randomly crashes. I had been on a slightly old version so I upgraded to the latest build, but I'm still getting the same crash.

System Details

Here's the debug output when I run Thorium from the terminal.

12:30:29 ~ $ /Applications/Thorium.app/Contents/MacOS/Thorium
[2441:259:1028/123116.434285:ERROR:unexportable_key_mac.mm(348)] Unexportable keys unavailable because keychain-access-group entitlement missing or incorrect. Expected value: .org.chromium.Thorium.devicetrust
Warning: SetDeviceLostCallback is deprecated. Pass the callback in the device descriptor instead.
[2441:259:1028/123116.559286:ERROR:chrome_web_ui_controller_factory.cc(520)] Requested load of chrome://newtab/ for incorrect profile type.
[2441:38147:1028/123119.024372:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT
Created TensorFlow Lite XNNPACK delegate for CPU.
[2441:34819:1028/123119.093520:ERROR:unexportable_key_mac.mm(348)] Unexportable keys unavailable because keychain-access-group entitlement missing or incorrect. Expected value: .org.chromium.Thorium.unexportable-keys
Attempting to use a delegate that only supports static-sized tensors with a graph that has dynamic-sized tensors (tensor#180 is a dynamic-sized tensor).
[2441:38147:1028/123142.545114:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT
[1028/123143.201709:WARNING:in_range_cast.h(38)] value -634136515 out of range
[1028/123143.235484:WARNING:crash_report_exception_handler.cc(235)] UniversalExceptionRaise: (os/kern) failure (5)
zsh: trace trap  /Applications/Thorium.app/Contents/MacOS/Thorium
12:34:57 ~ $ /Applications/Thorium.app/Contents/MacOS/Thorium
[5418:259:1028/123506.110469:ERROR:unexportable_key_mac.mm(348)] Unexportable keys unavailable because keychain-access-group entitlement missing or incorrect. Expected value: .org.chromium.Thorium.devicetrust
Warning: SetDeviceLostCallback is deprecated. Pass the callback in the device descriptor instead.
[5418:259:1028/123506.237173:ERROR:chrome_web_ui_controller_factory.cc(520)] Requested load of chrome://newtab/ for incorrect profile type.
Created TensorFlow Lite XNNPACK delegate for CPU.
[5418:39171:1028/123508.488040:ERROR:registration_request.cc(291)] Registration response error message: DEPRECATED_ENDPOINT
[5418:41475:1028/123508.488738:ERROR:unexportable_key_mac.mm(348)] Unexportable keys unavailable because keychain-access-group entitlement missing or incorrect. Expected value: .org.chromium.Thorium.unexportable-keys
Attempting to use a delegate that only supports static-sized tensors with a graph that has dynamic-sized tensors (tensor#180 is a dynamic-sized tensor).
[1028/123521.079494:WARNING:in_range_cast.h(38)] value -634136515 out of range
[1028/123521.110364:WARNING:crash_report_exception_handler.cc(235)] UniversalExceptionRaise: (os/kern) failure (5)
zsh: trace trap  /Applications/Thorium.app/Contents/MacOS/Thorium

I browsed a bit with Google Chrome and did not run into this crash.

pixelpicnic commented 1 month ago

so far it seems to crash when accessing google services:

77vjdplu1N2h commented 1 month ago

I'm experiencing the same issue. It happens for multiple sites. It started happening around 10/26/2024 00:00 UTC for me.

I'm using MacOS 14.4 (23E214) on an Apple M3 MacBook Air.

After each of those progressively more severe options, it still crashed quickly. At most, I can get maybe one or two pages to load before it crashes most of the time. One example site where it crashes is www.google.com, but it also crashes for some non-Google sites like www.yahoo.com.

tybantarnusa commented 1 month ago

I'm also experiencing this issue using version 124.0.6367.218 on my MacBook Air (macOS Monterey 12.7.5).

For me, it's not just limited to Google-related services; it happens with any website. Initially, a site might load, but if I open another, it randomly crashes. When I relaunch Thorium, I can restore the previous sites, but it crashes every time I try to open a new site.

b4cedev commented 4 weeks ago

I'm experiencing this issue, too. Some days ago Thorium crashed one or two times, but after launching it again I could restore previous tabs and go on.

Today I tried to buy something on stoffel.de and it crashed again when heading to checkout. Afterwards restoring my open tabs reproducibly led to immediate crashes. Since then it also crashes immediately after opening various sites (google.com, mozilla.com, heise.de, stoffel.de, ...) even if there are no open tabs. Clearing the cache didn't help.

I'm using macOS 14.7 on M1 Max with Thorium 126.0.6478.231.

Alex313031 commented 4 weeks ago

@b4cedev @tybantarnusa @77vjdplu1N2h @ika-musuko @pixelpicnic Two days ago I got a MASSIVE influx of issues about the MacOS build suddenly crashing.

ITS NOT Thorium's fault. A MacOS update borked Chromium M129 and earlier. Confirmed by making some plain vanilla builds of Chromium as well as downloading official builds from woolyss.com, and they all crashed on MacOS if they were older than M130.

The problem is, I'm trying to find where they fixed it recently, and backport the fix to Thorium M128. The issue is FINDING THE FIX among the hundreds of commits that are made each day, spread across thousands of files, to the repo.

Me and @midzer are trying to fix this, because I don't want to have yet ANOTHER release where MacOS is behind.

pixelpicnic commented 4 weeks ago

@Alex313031 - greatly appreciated! Sorry to add to the pile - I did a search before creating the ticket and didn't see one.

I figured it was something along those lines since it didn't make sense for the browser to suddenly have an issue. is there a main issue I should link this to and I can just close this out as a duplicate.

Cheers

b4cedev commented 4 weeks ago

@Alex313031 thanks for the explanation and your effort for finding a fix! And thanks for Thorium in general!!

Shell32-Natsu commented 4 weeks ago

Perhaps you can take a look at https://chromium-review.googlesource.com/c/chromium/src/+/5773370

pixelpicnic commented 4 weeks ago

Closing as duplicate of #67

Alex313031 commented 3 weeks ago

@b4cedev @tybantarnusa @77vjdplu1N2h @ika-musuko @pixelpicnic

Reopening to tag people here with an answer that may not be in the other issue. Will post the same thing there.

I fixed it by completely disabling all optimization guide stuff. I don't even know what all this code is or what it does, just that it borks MacOS. So look at my funny little constexpr block that fixes it:

constexpr auto fix_borked_macos_build =
#if BUILDFLAG(IS_MAC)
    base::FEATURE_DISABLED_BY_DEFAULT;
#else
    base::FEATURE_ENABLED_BY_DEFAULT;
#endif

Just gotta have @midzer compile it. Will also try to un-fuck the x64 builds this round too, because people on Intel Mac are still stuck on M124! Which actually would worry me about security vulnerabilities.

ika-musuko commented 1 week ago

Thanks for your hard work! @Alex313031

Do we have a build ready yet? What's the timeline for it?