Alex4SSB / ADB-Explorer

A fluent UI for ADB on Windows
MIT License
354 stars 29 forks source link

Program crashes when I try to do more than one operation consecutively #183

Closed cobbles-and-tatter closed 10 months ago

cobbles-and-tatter commented 10 months ago

I'm using ADB Explorer to transfer large quantities of pictures and videos from my phone to my computer, via USB. I use the "pull" command to bring a batch of 28 files at a time from my phone over to a folder on my computer, and then delete the 28 files. However, every other command causes ADB Explorer to crash. If I pull the files, it'll crash when I delete them. At which point, I start ADB Explorer again, go to the 28 files I was trying to delete, and then successfully delete them. Then, when I try to pull another batch of 28, ADB Explorer crashes again.

I have a very rigid method because verifying that I've safely transferred the files is the most important part to me.

I'm using a Pixel 4a and a Windows 11 computer.

I've tried adjusting various settings on ADB Explorer, to no avail. I've also trying running as an administrator. It might be related to settings on my phone, but I have no idea which ones would be relevant.

Alex4SSB commented 10 months ago

Regarding verifying the transfer - this feature is ready and will be available in the next version release, hopefully within a month (this is done by running a hash check on the source and the target, thus verifying all files from the source exist in the destination, with the contents intact).

Regarding the crashes - please check if refreshing the current location before deleting the files helps, and if anything changes in the folder after refreshing.

cobbles-and-tatter commented 10 months ago

Tried refreshing on the ADB Explorer side and the Windows Explorer side, neither prevented a crash.

Actually, that might be a relevant detail: I have both Explorers open simultaneously.

Alex4SSB commented 10 months ago

No, Windows Explorer shouldn't affect us.

And just to summarize, your scenario is:

  1. Pull 28 files from Android to PC, using ADB Explorer
  2. Refresh, or don't, the current folder in ADB Explorer
  3. Delete those 28 files on Android using ADB Explorer
  4. ADB Explorer crashes
cobbles-and-tatter commented 10 months ago

I couldn't find the refresh button or a key to refresh it, so I just exited the folder I was in and re-entered it, which I'm pretty sure works the same. With or without the refresh, ADB Explorer crashes.

I have also tested something else out: Trying to pull files consecutively also causes ADB Explorer to crash.

It might have something to do with another part of my process: Every time I pull 28 files, I put it into a new folder (to be sorted out later)

Alex4SSB commented 10 months ago

Ok, I just tried this in the last released version, and I see the crash. The crash happens when you begin a new file operation while having more than one completed operation in the current operations view. This is already not an issue anymore in the next version, since this mechanism changed.

For now, you can either delete all operations before starting a new batch, or perform one operation at a time. Sorry for the inconvenience, hope the next version will be much more helpful since it improves the whole file operations experience

cobbles-and-tatter commented 10 months ago

Great! Thank you so much. And no worries for the inconvenience- you've made a great, incredibly helpful program that I've had a great time using even with the crashing problem.