search

Alex4SSB / ADB-Explorer

A fluent UI for ADB on Windows
MIT License
400 stars 33 forks source link

bug: object reference not set to an instance of an object #198

Closed nutpantz closed 5 months ago

nutpantz commented 5 months ago

pixel 8 pro windows 10 android 14 /sdcard/Documents /sdcard/Downloads

errors out trying to pull those directory pulls the contents fine if i go in and highlight them

Alex4SSB commented 5 months ago

I'll need you to provide more info to be able to inspect this issue. If you could do a screen recording video of it, it would be best.

nutpantz commented 5 months ago

https://github.com/Alex4SSB/ADB-Explorer/assets/12160507/f57bb486-be33-40ae-91ad-7fff3e055d1d

nutpantz commented 5 months ago

now its working on my pixel 8 pro but not working on my blackview android 9 ill try later on my pixel 6 A13

Alex4SSB commented 5 months ago

Well, I didn't manage to find a possible reason for your issue, but I did find 2 other issues from your recording πŸ˜….

  1. The dialog window title showed the folder's whole string instead of just the name. Somehow it never happened to me, but I found the reason.
  2. To the left of the battery indicator, where you have 2 boxes - that's the ADB transfer rate indicator. Some Windows 10 installations don't render some font icons. It's actually 2 arrows being filled in when ADB is writing/reading from disk.

Back to your issue, I think the best course of action is for you to try to execute the command yourself in cmd. You can enable command log in the settings to see the command executed, I would suggest disabling the polling for devices option during this to minimize the commands in the log. Then when you execute the command in cmd, I would like to see the response you get.

Also, are other folders from the same location cause this issue? Especially those created by Android (Movies, Music, Notifications).

nutpantz commented 5 months ago

From what I can gather, it's a issue between file name conflicts on each os. More specificfly Linux allows special characters that ntfs or exfat will not. So you get the error. No way to fix it unless the files could be checked and auto renamed to NTFS standards. Which could be done of someone thought it with the effort. I have run into this issue on a VM copying files. And once 7zip extracted a Linux filename into NTFS and I could not delete it since no windows system command could read the filename but double commander for windows Displayed it.

On June 9, 2024 11:51:27 AM PDT, Alex B @.***> wrote:

Well, I didn't manage to find a possible reason for your issue, but I did find 2 other issues from your recording πŸ˜….

  1. The dialog window title showed the folder's whole string instead of just the name. Somehow it never happened to me, but I found the reason.
  2. To the left of the battery indicator, where you have 2 boxes - that's the ADB transfer rate indicator. Some Windows 10 installations don't render some font icons. It's actually 2 arrows being filled in when ADB is writing/reading from disk.

Back to your issue, I think the best course of action is for you to try to execute the command yourself in cmd. You can enable command log in the settings to see the command executed, I would suggest disabling the polling for devices option during this to minimize the commands in the log. Then when you execute the command in cmd, I would like to see the response you get.

-- Reply to this email directly or view it on GitHub: https://github.com/Alex4SSB/ADB-Explorer/issues/198#issuecomment-2156736922 You are receiving this because you authored the thread.

Message ID: @.***>

Alex4SSB commented 5 months ago

Have you figured out which characters exactly are causing the issue? Indeed on Unix based file systems, the only char that is forbidden in file name is /, but that's not the case with Android, which forbids the same chars as NTFS: " * / : < > ? \ |. Also, all [non-private-use] Unicode chars are allowed, which includes font icons & emoji.

Alex4SSB commented 5 months ago

Update: I just found a file name that breaks the app for me: ' 三体 πŸ•Ο€Ξ© (but the pull still completes). Will investigate it now.

nutpantz commented 5 months ago

not all andorid devices are the same. some have external storage that uses exfat others use fat32 .many custom roms use ext4 or ext3 then there is internal storage, external storage and usb drives now. ( with total commander on pixel 8 android 14 i can rename files with : < > |( i just checked.))

i am pretty sure it was "|" from a filename for webpage i saved.( auto named pdf or html) ( i have issues with | and : every few months, just long enough to forget about the issue)

Alex4SSB commented 5 months ago

I see. I'll try to add handling of these chars, and apparently we also have an issue in AdbProgressRedirection with handling emoji.