search

AlexAltea / unicorn.js

Unicorn CPU emulator framework port for JavaScript
https://alexaltea.github.io/unicorn.js/
GNU General Public License v2.0
566 stars 36 forks source link

ARM64 registers are repeated in unicorn_constants.js #33

Closed qwergle closed 2 years ago

qwergle commented 2 years ago

A little background: Currently, I'm trying to write (at least some of) the documentation for the constants. From reading unicorn_constants.js before, I know that there are three parts to it: register constants, X86 instruction constants, and Unicorn engine constants. So, I decide to use Control-F to find each register and create a placeholder. I find that at the very end, the list of ARM64 registers (the list at the very beginning of the file) is repeated at the end. I realize that it's auto-generated and that it says explicitly not to edit it, but it should be edited to remove this redundancy.

AlexAltea commented 2 years ago

Nice catch, seems like the last line effect strikes again! 😄

Fixed at https://github.com/AlexAltea/unicorn.js/commit/6e998393d863a37659c09046d4835003e6554a35

AlexAltea commented 2 years ago

Just to clarify, build.py was at fault here.

qwergle commented 2 years ago

Just to clarify, build.py was at fault here.

I thought so. After all, it was made by build.py.