Pass proxy in on DMS downloads

AlexAplin / nndownload

Download and process links from Niconico (nicovideo.jp)

MIT License

213 stars 28 forks source link

Pass proxy in on DMS downloads #150

Closed AlexAplin closed 2 months ago

AlexAplin commented 3 months ago

We don't pass ffmpeg -http-proxy currently. Don't think this prevents or blocks anything currently, but we should honor it when specified.

No support for SOCKS proxies: https://trac.ffmpeg.org/ticket/5776

UPDATE: We use the session again when performing HLS downloads in #159, so this should work as expected. Needs verification.

fireattack commented 2 months ago

From what I can see, the new hls_dl should already support proxies since it reuses the session we have which has .proxies updated with CLI arguments.

Needs someone to test it.

AlexAplin commented 2 months ago

@xyzxye Maybe you can test if you're available?

xyzxye commented 2 months ago

Yes! HLS downloader can function normally with a proxy (without TUN), whether through source code or CLI. Thank your for your work!!!