search

AlexAplin / nndownload

Download and process links from Niconico (nicovideo.jp)
MIT License
213 stars 28 forks source link

Use custom ffmpeg class #152

Closed AlexAplin closed 3 months ago

AlexAplin commented 3 months ago

Fixes #151. Solution mostly borrowed from the Gist there. Our socket solution doesn't work on Windows (perhaps Python will supprot AF_UNIX some day: https://bugs.python.org/issue33408), so we now just read from stdout. Also we're fancy and rich now so our progress bar has colors.

AlexAplin commented 3 months ago

tqdm writes to stderr which means --quiet will not be respected. We could write to file=sys.stdout instead but I'm probably just going to implement --silent.

fireattack commented 3 months ago

Do we want to use import regex as re instead of just import re?

AFAIK regex is a 3rd-party package and it's not in requirement.txt ATM, and it looks to me its extended features are not needed in this case (not tested yet).