search

AlexAplin / nndownload

Download and process links from Niconico (nicovideo.jp)
MIT License
213 stars 28 forks source link

Native HLS downloader video and audio progress bars not hitting 100% correctly #165

Closed Prcuvu closed 2 months ago

Prcuvu commented 2 months ago

It seemed that the video and audio streams were downloaded successfully, but the progress bars failed to hit 100% before the next step.

AlexAplin commented 2 months ago

Are you sure this is the commit you quoted? The progress bars for video and audio download look like they're using tqdm.rich, but we switched to using rich.Progress with the introduction of the HLS downloader in feda112b781aeee8f328c6b63ea19149232e4c31.

For example, this is how the progress bars look now (notice no Downloading prefix and the lack of segment info):

image

Prcuvu commented 2 months ago

I cleaned site-packages and rebuilt, and the progress bars looked fine now.

image