AlexAplin / nndownload

Download and process links from Niconico (nicovideo.jp)
MIT License
223 stars 29 forks source link

Modularize nndownload #47

Closed jaeseopark closed 5 years ago

jaeseopark commented 5 years ago

Converted nndownload into a python module.

The standalone mode continues to work as it currently does. no changes there.

It's probably very hard to see what parts of the code changed, because diff in Git is all red and green. Here is a better view of what has changed exactly.

summary:

  1. changed how logger is initialized and used. This is to allow nndownload to inherit any log configurations from the caller-module.
  2. main() no longer calls sys.exit() when an exception is thrown. Instead, it simply bubbles the exception up, so the except block of the caller-module can do the rest.

I put the pypi badge in the README but haven't actually uploaded the package to pypi. It's on TestPyPi, though.

AlexAplin commented 5 years ago
AlexAplin commented 5 years ago

@jaeseopark Please add me as the owner of the package (https://pypi.org/user/AlexAplin/).

jaeseopark commented 5 years ago

Thanks for the reminder. I added you.

Do you know how to transfer the ownership entirely? I never intended to be an owner of this project.

AlexAplin commented 5 years ago

Thanks, I went ahead and removed you.