Add metadata tags to MP4 files

AlexAplin / nndownload

Download and process links from Niconico (nicovideo.jp)

MIT License

213 stars 28 forks source link

Add metadata tags to MP4 files #78

Closed Xyde closed 3 years ago

Xyde commented 3 years ago

youtube-dl already does this., where it embeds metadata directly to the video container.

AlexAplin commented 3 years ago

We can maybe do this for MP4. FLV/SWF, I don't believe those containers support adding metadata tags beyond the basic descriptors.

AlexAplin commented 3 years ago

I have this implemented but unfortunately it messes with resuming on incomplete files as embedded metadata changes the file length. I'll need to think about how to handle that.

AlexAplin commented 3 years ago

Write metadata to the container only when the video is done downloading
Change how integrity is checked on redownloading videos:
- Complete files
- If metadata tags exist, we can be confident the file is complete; MP4StreamInfoError thrown if not an MP4
- Otherwise if current size exceeds video length, server file must be of a different quality
- Incomplete files
- No change in behavior (can match on byte position with server)