search

AlexBieg / obsidian-better-command-palette

A better command palette for obsidian
MIT License
161 stars 12 forks source link

FR: edit Pinned Commands in the Better Commands Palette Settings #54

Open chrisgrieser opened 2 years ago

chrisgrieser commented 2 years ago

more of a convenience feature, but since the BCP is supposed to be a command palette replacement, I think it should offer some settings to add/remove pins in its own settings.

Right now, i do have to re-enable the core plugin command palette to change any pinned commands there, and then disable it again, which feels a bit clumsy.

AlexBieg commented 2 years ago

Honestly totally agree. I made this functionality right when I first developed the plugin and it no longer makes a lot of sense. I don't think this is particularly good UI/UX and would like to rework it. I'll add this to the queue

For my own notes there are a few considerations:

  1. Backwards Compatibility: People have been using this as-is for a while and have likely gotten their pins in a comfortable setup. Time should be given to seeing how hard it would be to automatically port those to whatever new system is made here. Maybe some sort of button in the settings would be able to do this.
  2. Double check if there are any other places where we use the base command palette functionality. I can't think of any off the top of my head but I want to be certain.
Fred-Vatin commented 4 months ago

As implementation, the same way we can hide an entry with a button, the pin icon could reveal next to the cross icon, we could pin/unpinned with a click on it. Currently, clicking on an existent pin icon of pinned entry hides it. This is not what I would expect.

image