search

AlexCSDev / PatreonDownloader

Powerful tool for downloading content posted by creators on patreon.com. Supports content hosted on patreon itself as well as external sites (additional plugins might be required).
MIT License
917 stars 95 forks source link

Space in regex causing failure #197

Closed Skyl3lazer closed 9 months ago

Skyl3lazer commented 11 months ago

https://github.com/AlexCSDev/PatreonDownloader/issues/196

Addresses this issue. The space in that regex fails to find the campaign text. Not sure if that space changed or needs to be made optional.

AlexCSDev commented 11 months ago

Thank you for the PR. I'm currently on a vacation, so I will check this when I'll get back.

For now the only comment I have is that it's more future-proof to make that space optional instead of removing it altogether. If you can make that change that will be great.

Skyl3lazer commented 11 months ago

Done! https://github.com/AlexCSDev/PatreonDownloader/pull/197/commits/802ee19351bb5bada3747c765caa7ef24fa48e6e

WinterSoldier1234 commented 10 months ago

Screenshot 2023-09-29 130020 Unfortunately even after following the steps

AlexCSDev commented 10 months ago

Small update - current plan for reviewing this is sometime next week