AlexChesser
commented
3 years ago Another story! In 2015 I was super excited by kubernetes and was playing with it on a weekend.
One of the steps in the documentation was missing and it took me a few hours to find the solution. I wanted to help the next person that came behind me, and this one line documentation commit might seem stupid, small or not very useful .. .but I think it added value in a couple ways.
- someone coming to kubernetes for the first time would be less likely to struggle to get the system working from scratch. That's good for the person.
- if someone can successfully set up k8s on their first try, they are more likely to select the technology for their projects. That's good for kubernetes.
That's a digression ... but it was the first time I saw the acronym LGTM - "looks good to me"
https://github.com/kubernetes/kubernetes/pull/17552
I was so proud of that I was probably about 40 years old and giggling like a kid and would tell anyone who'd listen that I just had a PR accepted by google.
LGTM feels real good to see.
This is maybe a cute story. I certainly think it is cool.
Though my memory is actually a bit foggy on the topic since I could have sworn for the life of me that I had a PR accepted in an actual microsoft repostitory.
(but it might be that this was the first PR I contributed to open source on github where I saw the shipit squirrel :shipit: https://github.com/OmniSharp/generator-aspnet/pull/530 )
There's a pretty interesting and funny backstory to the squirrel itself.