search

AlexConnat / PracticeJazzChords

A simple web application to help you practice your Jazz chords using a MIDI keyboard, directly in your browser
GNU General Public License v3.0
0 stars 0 forks source link

Refactor the utility functions #5

Open AlexConnat opened 2 years ago

AlexConnat commented 2 years ago

A lot of functions in this code have a very unique purpose, and could be written in a separate utils.js file. They could even be tested individually by unit tests. Bigger functions could be split in smaller functional modules.

For instance, a function that takes as an input a chord, and a list of chord tones and extensions (e.g: 3rd, 7th and 9th), and return what these chord tones and extensions are, for this particular chord. Example: With a C7b9 chord, the function would return ['E', 'Bb', 'Db']

lewisyng commented 2 years ago

Hey, I'd like to do this issue :)