In the file writer factory, we currently initialize writers with the expanded filesystem path.
This is great for writing files locally, but I would like to be able to roll my own filewriter/factory that write the combined file to amazon s3 (or any cdn really) where the relative path is more important.
In two of the places we call GetFileWriter currently we could easily pass local and expanded paths and defer to the factory to decide which matters. In the other spot (part of the rendering process IIRC) we only have the expanded path.
In a perfect world I would like to pass relative paths down to GetFileWriter and allow the factory to expand them as needed. Its probably a not-insignificant change but it should be possible.
This is probably more of a 0.9.x than a 0.9 issue but I will optimistically tag it for 0.9
AlexCuse
commented
12 years ago
In the file writer factory, we currently initialize writers with the expanded filesystem path.
This is great for writing files locally, but I would like to be able to roll my own filewriter/factory that write the combined file to amazon s3 (or any cdn really) where the relative path is more important.
In two of the places we call GetFileWriter currently we could easily pass local and expanded paths and defer to the factory to decide which matters. In the other spot (part of the rendering process IIRC) we only have the expanded path.
In a perfect world I would like to pass relative paths down to GetFileWriter and allow the factory to expand them as needed. Its probably a not-insignificant change but it should be possible.
This is probably more of a 0.9.x than a 0.9 issue but I will optimistically tag it for 0.9