search

AlexDenisov / iActiveRecord

ActiveRecord for iOS without CoreData, only SQLite
http://alexdenisov.github.com/iActiveRecord/
MIT License
354 stars 50 forks source link

Fixes belonsg -> belongs typo in macro #15

Closed pwightman closed 12 years ago

pwightman commented 12 years ago

A small typo in the macro that cost me a few minutes of debugging :-) Fixed in both ARRelationshipsHelper.h and TestSources/Issue.m, TestSources/User.m.

pwightman commented 12 years ago

I can't imagine this will mess up unit tests, but I'm trying to run them anyway but it can't find Cedar-iOS/SpecHelper.h. Is this supposed to be installed separately? If so, is there a preferred way? Thanks.

AlexDenisov commented 12 years ago

I'll merge your PR as patch manually, because I need to merge it into stable branch, not in master. To install cedar you should run this shell script.

AlexDenisov commented 12 years ago

Merged with branch stable. You can checkout new tag 1.3.2

pwightman commented 12 years ago

Excellent. And if you don't mind, I'll update the Wiki page with a Contributing section explaining how to install Cedar and to be sure to run unit tests before submitting pull requests?

AlexDenisov commented 12 years ago

Yes, sure, thanks for help ;-)

AlexDenisov commented 12 years ago

@pwightman, I've fixed the issue with the Cedar dependencies. From now if you want to run UnitTests you should install(build) Cedar and link Cedar-iOS.framework into UnitTests target. After that just build&run specs target. Don't forget - any fixes/improvements should refer to the 'stable' branch, not to master. If you still have any questions - feel free to ask ;-)

pwightman commented 12 years ago

Excellent! I'll give this a go and make sure I can get it installed without an issue, and then update the Wiki.

Thanks.

On Jul 31, 2012, at 2:08 PM, "alex.d" reply@reply.github.com wrote:

@pwightman, I've fixed the issue with the Cedar dependencies. From now if you want to run UnitTests you should install(build) Cedar and link Cedar-iOS.framework into UnitTests target. After that just build&run specs target. Don't forget - any fixes/improvements should refer to the 'stable' branch, not to master. If you still have any questions - feel free to ask ;-)

Reply to this email directly or view it on GitHub: https://github.com/AlexDenisov/iActiveRecord/pull/15#issuecomment-7409923