Duplicate Symbols using NSData+Base64 (Replace with Pod)

[neilabdev]

Excited about using iActiveRecord. I did notice that a common lib, NSData+Base64 is used by a lot of libraries, including MKStoreKit, causing duplicate Symbols. If you use add 'NSData+Base64' as a dependency, it should resolve the issue with other libraries if they did the same. Though in my case, even if this was done, it would not solve my issue because though MKStoreKit renames the category, the static methods have the same name :(

  pod 'NSData+Base64'

[AlexDenisov]

As a hotfix you may send me a PR with fixed method names.

[neilabdev]

Here you go: https://github.com/AlexDenisov/iActiveRecord/pull/74 uses the Podfile dependency. Or did you prefer renamed NSData categories? Also, never did a forked repository pull request before, not sure I did it correctly. The original commit is here: https://github.com/valerius/iActiveRecord/commit/b78adaafd2365941142c1a7444047d7bf0184ff5

[neilabdev]

It just occurred to me you may wan't others besides those that use CocoaPods to have NSData+Base64 compat. Wherefore, the best solution is just to modify your spec file as follows:

  s.exclude_files = "iActiveRecord/NSData+Base64.{h,m}"
  s.dependency "NSData+Base64"

Im working fine without the change as of now as I removed the other conflicts. Just an FYI.

[AlexDenisov]

Sorry for delay. The problem is that I can't merge your PR automatically, looks like you use old version or different branch. Could you check it out?

[neilabdev]

Hey! No rush… and forgive my delay also. I’ve used github pull request before, but never cross project fork. While did create a pull request, I see someone else’s commits besides mine which indicates I may not be starting from the right place. The last release was tag 1.3.2. Wherefore, I git checkout -b my_brang_name 1.3.2 , yet, I still see there commit in addition to mine, and you may not want to merge both. What branch should I be applying changes to, and I’ll figure the github interface my next window. Thanks!

On Mar 18, 2014, at 11:31 AM, Alexey Denisov notifications@github.com wrote:

Sorry for delay. The problem is that I can't merge your PR automatically, looks like you use old version or different branch. Could you check it out?

— Reply to this email directly or view it on GitHub.

[AlexDenisov]

You should use master branch directly. 1.3.2 is obsoleted and has a lot of bugs (btw, master too).

[neilabdev]

Just thought I'd followup and let you know I think your :master code is fine. I'm now doing a local include until next release. The issue is that while your :master code is working which may be versioned at "1.9", the pod spec on CocoaPods refers to tag 1.3.2, which has the issue. Therefore the problem will resolve itself next release. Nevertheless, thanks for the great API, meanwhile I'm creating a category with various help routines that I can happily share after competition (though only residing in the main app at the moment). Anyways, Im closing the ticket :)

[AlexDenisov]

@valerius, thank you for the feedback and contribution.