AlexDisler / cordova-icon

Automatic icon resizing for Cordova
MIT License
689 stars 292 forks source link

Icon location #56

Closed TheGoat96 closed 8 years ago

TheGoat96 commented 8 years ago

Icon location for Cordova CLI iOS@4.0.1 has changed.

BrunoCartier commented 8 years ago

Hey,

With this code, what happens if someone uses the library when developing an app with an older Cordova CLI version?

TheGoat96 commented 8 years ago

I’m assuming that they will get an warning during the build that the folder could not be reached or found, just like you would using the newer version with the current code. The app will still build, but Cordova will use it’s default icon. The user would have to manually create the folder(s) in Xcode to place icons in.

Sheldon Bradley,

On Feb 10, 2016, at 6:14 PM, Bruno Cartier notifications@github.com wrote:

Hey,

With this code, what happens if someone uses the library when developing an app with an older Cordova CLI version ?

— Reply to this email directly or view it on GitHub https://github.com/AlexDisler/cordova-icon/pull/56#issuecomment-182630835.

gardner commented 8 years ago

It seems to me that this repo is no longer maintained. @AlexDisler where are you?

AlexDisler commented 8 years ago

Just merged it, thank you

gardner commented 8 years ago

Thank you @AlexDisler :)