search

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping
https://curseforge.com/wow/addons/autogear
Other
8 stars 11 forks source link

RETAIL. Api changed 10.0.2 And Autogear is totally broken #40

Closed ollyvs closed 8 months ago

ollyvs commented 1 year ago

https://wowpedia.fandom.com/wiki/Patch_10.0.2/API_changes

ncplus0 commented 1 year ago

9873x Interface/AddOns/AutoGear/AutoGear.lua:364: attempt to call global 'AutoGearMain' (a nil value) [string "@Interface/AddOns/AutoGear/AutoGear.lua"]:364: in function <Interface/AddOns/AutoGear/AutoGear.lua:363>

Locals: (temporary) = nil (temporary) = "attempt to call global 'AutoGearMain' (a nil value)"

AlexFolland commented 1 year ago

This error doesn't make sense without earlier errors. What's the first error in the session in BugSack?

ncplus0 commented 1 year ago

there is 5 diferent erros but since is always counting i cant copy them, do you kwon a way to do it?

ncplus0 commented 1 year ago

2x FrameXML\Bindings.xml:1 Interface/AddOns/AutoGear/AutoGear.lua:1 (null

ncplus0 commented 1 year ago

12x Interface/AddOns/AutoGear/AutoGear.lua:1 (null)

ncplus0 commented 1 year ago

4x Interface/AddOns/AutoGear/AutoGear.lua:2621: attempt to call global 'GetContainerNumSlots' (a nil value) [string "@Interface/AddOns/AutoGear/AutoGear.lua"]:2621: in function `AutoGearConsiderAllItems' [string "@Interface/AddOns/AutoGear/AutoGear.lua"]:2061: in function <Interface/AddOns/AutoGear/AutoGear.lua:1803>

Locals: lootRollItemID = nil questRewardID = nil arbitraryItemInfo = nil noActions = true anythingBetter = nil info = nil (for index) = 0 (for limit) = 4 (for step) = 1 bag = 0 (temporary) = nil (temporary) = 0 (*temporary) = "attempt to call global 'GetContainerNumSlots' (a nil value)" futureAction =

{ 1 =
{ } }

ncplus0 commented 1 year ago

13x Interface/AddOns/AutoGear/AutoGear.lua:4110: GameTooltip doesn't have a "OnTooltipSetItem" script [string "=[C]"]: in function `?' [string "@Interface/AddOns/AutoGear/AutoGear.lua"]:4110: in main chunk

Locals: (*temporary) = GameTooltip { 0 = SetQuestLogRewardSpell = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestPartyProgress = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessLineData = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:303 SetPvpTalent = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetRuneforgeResultItem = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetHyperlink = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetUnit = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetAzeriteEssence = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetVoidDepositItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetVoidWithdrawalItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetInfoBackdropStyle = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:338 SetTradeSkillItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 shoppingTooltips =

{ } SetSocketGem = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 updateTooltipTimer = 0.200000 ItemTooltip = Frame { } StatusBar = GameTooltipStatusBar { } SetLootCurrency = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetSlottedKeystone = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetWorldCursor = defined @Interface/FrameXML/GameTooltip.lua:952 SetLootItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetMerchantCostItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 GetUnit = defined @Interface/FrameXML/GameTooltip.lua:994 SetOwnedItemByID = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetItemInteractionItem = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestLogSpecialItem = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 TextRight1 = GameTooltipTextRight1 { } SetEnhancedConduit = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetRecipeReagentItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetQuestCurrency = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 supportsDataRefresh = true SetWeeklyReward = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetMerchantItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 SetPvpBrawl = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetAchievementByID = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 BottomOverlay = Texture { } SetSpellByID = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 supportsItemComparison = true SetSocketedRelic = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessInfo = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:236 ProcessLines = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:293 NineSlice = Frame { } SetInventoryItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ItemTooltipClasses/Wrapper.lua:109 RefreshData = defined @Interface/FrameXML/GameTooltip.lua:933 SetTransmogrifyItem = defined @Interface/SharedXML/Tooltip/TooltipDataHandler.lua:444 SetLootRollItem = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/It

ncplus0 commented 1 year ago

the rest is does not show more

AlexFolland commented 1 year ago

Thanks for the error messages. Remember that you can wrap them in code block tags, starting and ending with 3 grave symbols.

Blizzard changed how tooltip-scanning and tooltip-modifying works, and AutoGear relies on that. I don't have time right now to update AutoGear specifically for mainline to work with the new changes, so I've released a version which does not claim to support mainline 10.0.2 for now. I may update it soon. In the mean time, pull requests are welcome.

padic-dev commented 1 year ago

Attached is the file I modified to clear the errors. It's not fully fixed as it doesn't seem to auto equip when new gear is added to the bag. I only tested with creating heirlooms which worked before patch 10.0.2 but does not work with my changes.

I think it's related to the code in lines 2850-2851. I modified it to clear the error but it's not "auto" equipping. The button in the options menu does make it equip gear as expected.

Also I don't use the full suite of features, I only use this add-on for auto equipping so there may be more errors I have not come across with some of the other features.

Hopefully this helps someone finish up the stuff I could not figure out.

AutoGear.lua.txt

ncplus0 commented 1 year ago

with the padic update ive found 2 errors, but addon work with my druid but not in my evoker, but only by using the scan buton in the interface

105x AutoGear/AutoGear.lua:3941: attempt to call method 'IsEquippedItem' (a nil value) [string "@AutoGear/AutoGear.lua"]:3941: in function <AutoGear/AutoGear.lua:3937>

[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106> [string "=[C]"]: in functionSetAttribute' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <SharedXML/Tooltip/TooltipDataHandler.lua:240> [string "=[C]"]: in function `securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236>

[string "@AutoGear/AutoGear.lua"]:3062: in function AutoGearReadItemInfo' [string "@AutoGear/AutoGear.lua"]:2568: in functionAutoGearUpdateEquippedItems' [string "@AutoGear/AutoGear.lua"]:1811: in function <AutoGear/AutoGear.lua:1803>

Locals: tooltip = AutoGearTooltip { 0 = SetQuestLogRewardSpell = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestPartyProgress = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessLineData = defined @SharedXML/Tooltip/TooltipDataHandler.lua:303 SetPvpTalent = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetRuneforgeResultItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetHyperlink = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetUnit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetAzeriteEssence = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetVoidDepositItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetVoidWithdrawalItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetInfoBackdropStyle = defined @SharedXML/Tooltip/TooltipDataHandler.lua:338 hasMoney = 1 shownMoneyFrames = 1 SetSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 numMoneyFrames = 1 info =

{ } updateTooltipTimer = 0.200000 SetLootCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetSlottedKeystone = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetWorldCursor = defined @FrameXML/GameTooltip.lua:952 SetLootItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 StatusBar = AutoGearTooltipStatusBar { } GetUnit = defined @FrameXML/GameTooltip.lua:994 SetOwnedItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetMerchantCostItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestLogSpecialItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetItemInteractionItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 TextRight1 = AutoGearTooltipTextRight1 { } SetRecipeReagentItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetEnhancedConduit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetWeeklyReward = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetMerchantItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetPvpBrawl = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetAchievementByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 BottomOverlay = Texture { } SetSpellByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 supportsDataRefresh = true SetSocketedRelic = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:236 ProcessLines = defined @SharedXML/Tooltip/TooltipDataHandler.lua:293 NineSlice = Frame { } SetInventoryItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 RefreshData = defined @FrameXML/GameTooltip.lua:933 SetTransmogrifyItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetLootRollItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 OnLoad = defined @FrameXML/GameTooltip.lua:927 SetQuestLogCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetUnitDebuffByAuraInstanceID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetBagItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 GetSpell = defined @Fra

and also the error

48x AutoGear/AutoGear.lua:3940: attempt to call method 'GetItem' (a nil value) [string "@AutoGear/AutoGear.lua"]:3940: in function <AutoGear/AutoGear.lua:3937>

[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106> [string "=[C]"]: in functionSetAttribute' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:282: in function <SharedXML/Tooltip/TooltipDataHandler.lua:240> [string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:237: in functionProcessInfo' [string "@SharedXML/Tooltip/TooltipComparisonManager.lua"]:249: in function SetItemTooltip' ... [string "@FrameXML/GameTooltip.lua"]:527: in functionGameTooltip_ShowCompareItem' [string "@WorldQuestTab/Templates.lua"]:602: in function <WorldQuestTab/Templates.lua:534> [string "@WorldQuestTab/Templates.lua"]:666: in function AddQuestRewardsToTooltip' [string "@WorldQuestTab/Dataprovider.lua"]:84: in function <WorldQuestTab/Dataprovider.lua:81> [string "@WorldQuestTab/Dataprovider.lua"]:212: in functionLoadRewards' [string "@WorldQuestTab/Dataprovider.lua"]:153: in function Init' [string "@WorldQuestTab/Dataprovider.lua"]:686: in functionAddQuest' [string "@WorldQuestTab/Dataprovider.lua"]:657: in function AddQuestsInZone' [string "@WorldQuestTab/Dataprovider.lua"]:523: in functionOnUpdate' [string "@WorldQuestTab/Dataprovider.lua"]:470: in function <WorldQuestTab/Dataprovider.lua:470>

Locals: tooltip = WQT_CompareScrapeTooltip1 { 0 = SetQuestLogRewardSpell = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestPartyProgress = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessLineData = defined @SharedXML/Tooltip/TooltipDataHandler.lua:303 SetPvpTalent = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetExistingSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetHyperlink = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetUnit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetAzeriteEssence = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetVoidDepositItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetVoidWithdrawalItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetInfoBackdropStyle = defined @SharedXML/Tooltip/TooltipDataHandler.lua:338 SetSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetLootCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetSlottedKeystone = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetItemInteractionItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetLootItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetOwnedItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestLogSpecialItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetRecipeReagentItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetBuybackItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 hasMoney = 1 SetWeeklyReward = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetMerchantItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetPvpBrawl = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 shownMoneyFrames = 1 BottomOverlay = Texture { } SetSpellByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 numMoneyFrames = 1 SetSocketedRelic = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 ProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:236 ProcessLines = defined @SharedXML/Tooltip/TooltipDataHandler.lua:293 NineSlice = Frame { } SetInventoryItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 info =

{ } updateTooltipTimer = 0.200000 SetLootRollItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 InternalProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:240 SetPossession = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetUnitDebuffByAuraInstanceID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetBagItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 TextRight1 = WQT_CompareScrapeTooltip1TextRight1 { } SetAction = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetLineDataAttribute = defined @SharedXML/Tooltip/TooltipDataHandler.lua:232 SetAchievementByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetInventoryItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetCurrencyByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetQuestLogCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:444 SetBagItemChild =

padic-dev commented 1 year ago

I expect to have free time this weekend. I still need to buy the xpac and renew game time however if the beta is still active by this weekend I can do a deeper dive than my initial fixes. The changes were mainly for my fiancé so she was able to hit the ground running when the Dragonflight dropped.

I will update when I have more info.

padic-dev commented 1 year ago

I did a new round of updates, started from scratch this time making targeted fixes for changes from 10.0.0 to 10.0.2. I also registered a new event to monitor bag updates which seems to allow the auto-equip feature to work again. Hopefully this will do a bit better than my previous attempt. Feel free to post any issues, I will do my best until Alex can make an official update.

I was not able to do a ton of deep testing as of yet. I was limited to the trial limits as I still have not added game time, nor was I able to test Evokers, still have not purchased DragonFlight.

The basic tests I ran were:

removing gear to bag causes it to reequip immediately creating an heirloom causes it to equip immediately turning in a quest with item reward will equip item immediately (used the legion intro quest which rewards a ring)

AutoGear.lua.txt

AlexFolland commented 1 year ago

Thank you for opening a pull request! I've left a code review of your pull request.

removing gear to bag causes it to reequip immediately

By the way, this is not the intended behavior, so it's concerning that this happened. It means AutoGear would be fighting the player directly instead of allowing them the comfort of moving items in their inventory until they're ready for a scan. AutoGear should only automatically equip an item under these circumstances:

  • the player's character receives a gear item for the first time from outside their inventory, like from a loot roll, vendor, craft, or quest reward
  • the player's character's gear evaluation situation changes, like when changing specialization
  • the player has manually initiated a scan

I have left the same comment in the pull request review, so please respond to this there instead of here.

creating an heirloom causes it to equip immediately turning in a quest with item reward will equip item immediately (used the legion intro quest which rewards a ring)

That being said, these behaviors are both intended, so it's good that they both worked as intended.

ncplus0 commented 1 year ago

on the evoker still does not work, also the options menu does not apear

200x AutoGear/AutoGear.lua:1564: attempt to index field '?' (a nil value) [string "@AutoGear/AutoGear.lua"]:1564: in function AutoGearSetStatWeights' [string "@AutoGear/AutoGear.lua"]:2562: in functionAutoGearUpdateEquippedItems' [string "@AutoGear/AutoGear.lua"]:1811: in function <AutoGear/AutoGear.lua:1803>

Locals: class = "EVOKER" spec = "None" (temporary) = nil (temporary) = "EVOKER" (temporary) = "None" (temporary) = 13 (*temporary) = "attempt to index field '?' (a nil value)" TOC_VERSION_CURRENT = 100002 TOC_VERSION_WOTLK = 30000 weapons = nil

AlexFolland commented 1 year ago

The pull request for resolving this ticket's issue is still in progress. Please feel free to monitor it at https://github.com/AlexFolland/AutoGear/pull/42 for the latest updates.

By the way, this ticket is not about evokers specifically.

ncplus0 commented 1 year ago

getting error after latest release 2023-01-27

65x AutoGear/AutoGear.lua:3963: attempt to call method 'IsEquippedItem' (a nil value) [string "@AutoGear/AutoGear.lua"]:3963: in function <AutoGear/AutoGear.lua:3959>

[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106> [string "=[C]"]: in functionSetAttribute' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:278: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236> [string "=[C]"]: in function `securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:233: in function <SharedXML/Tooltip/TooltipDataHandler.lua:232>

[string "@AutoGear/AutoGear.lua"]:3084: in function AutoGearReadItemInfo' [string "@AutoGear/AutoGear.lua"]:2590: in functionAutoGearUpdateEquippedItems' [string "@AutoGear/AutoGear.lua"]:1815: in function <AutoGear/AutoGear.lua:1807>

Locals: tooltip = AutoGearTooltip { 0 = SetQuestLogRewardSpell = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetQuestPartyProgress = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 ProcessLineData = defined @SharedXML/Tooltip/TooltipDataHandler.lua:299 SetPvpTalent = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetRuneforgeResultItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetHyperlink = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetUnit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetAzeriteEssence = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetVoidDepositItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetVoidWithdrawalItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetInfoBackdropStyle = defined @SharedXML/Tooltip/TooltipDataHandler.lua:334 SetSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 info =

{ } SetLootCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetSlottedKeystone = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetWorldCursor = defined @FrameXML/GameTooltip.lua:952 SetLootItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 updateTooltipTimer = 0.200000 GetUnit = defined @FrameXML/GameTooltip.lua:994 SetOwnedItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 StatusBar = AutoGearTooltipStatusBar { } SetQuestLogSpecialItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetBagItemChild = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetItemInteractionItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetRecipeReagentItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetQuestCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 TextRight1 = AutoGearTooltipTextRight1 { } SetWeeklyReward = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetMerchantItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetMerchantCostItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetEnhancedConduit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 BottomOverlay = Texture { } SetSpellByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 AddLineDataText = defined @SharedXML/Tooltip/TooltipDataHandler.lua:320 SetSocketedRelic = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 ProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:232 ProcessLines = defined @SharedXML/Tooltip/TooltipDataHandler.lua:289 NineSlice = Frame { } SetInventoryItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 supportsDataRefresh = true SetUnitAura = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetLootRollItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetTransmogrifyItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 RefreshData = defined @FrameXML/GameTooltip.lua:933 SetUnitDebuffByAuraInstanceID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetBagItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 OnLoad = defined @FrameXML/GameTooltip.lua:927 SetAction = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 GetSpell = <functio

ncplus0 commented 1 year ago

and also

10x AutoGear/AutoGear.lua:3962: attempt to call method 'GetItem' (a nil value) [string "@AutoGear/AutoGear.lua"]:3962: in function <AutoGear/AutoGear.lua:3959>

[string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:60: in function <SharedXML/Tooltip/TooltipDataHandler.lua:55> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:80: in function <SharedXML/Tooltip/TooltipDataHandler.lua:76> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:116: in function <SharedXML/Tooltip/TooltipDataHandler.lua:106> [string "=[C]"]: in functionSetAttribute' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:141: in function <SharedXML/Tooltip/TooltipDataHandler.lua:134> [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:278: in function <SharedXML/Tooltip/TooltipDataHandler.lua:236> [string "=[C]"]: in function securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:233: in functionProcessInfo' [string "@SharedXML/Tooltip/TooltipComparisonManager.lua"]:249: in function SetItemTooltip' ... [string "@FrameXML/GameTooltip.lua"]:527: in functionGameTooltip_ShowCompareItem' [string "@WorldQuestTab/Templates.lua"]:602: in function <WorldQuestTab/Templates.lua:534> [string "@WorldQuestTab/Templates.lua"]:666: in function AddQuestRewardsToTooltip' [string "@WorldQuestTab/Dataprovider.lua"]:84: in function <WorldQuestTab/Dataprovider.lua:81> [string "@WorldQuestTab/Dataprovider.lua"]:212: in functionLoadRewards' [string "@WorldQuestTab/Dataprovider.lua"]:153: in function Init' [string "@WorldQuestTab/Dataprovider.lua"]:686: in functionAddQuest' [string "@WorldQuestTab/Dataprovider.lua"]:657: in function AddQuestsInZone' [string "@WorldQuestTab/Dataprovider.lua"]:523: in functionOnUpdate' [string "@WorldQuestTab/Dataprovider.lua"]:470: in function <WorldQuestTab/Dataprovider.lua:470>

Locals: tooltip = WQT_CompareScrapeTooltip1 { 0 = SetQuestLogRewardSpell = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetQuestPartyProgress = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 ProcessLineData = defined @SharedXML/Tooltip/TooltipDataHandler.lua:299 SetPvpTalent = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetExistingSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetHyperlink = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetUnit = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetAzeriteEssence = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetVoidDepositItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetVoidWithdrawalItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetInfoBackdropStyle = defined @SharedXML/Tooltip/TooltipDataHandler.lua:334 SetSocketGem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetLootCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetSlottedKeystone = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetItemInteractionItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetLootItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetOwnedItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetQuestLogSpecialItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetRecipeReagentItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetBuybackItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 updateTooltipTimer = 0.200000 SetWeeklyReward = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetMerchantItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetPvpBrawl = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 hasMoney = 1 BottomOverlay = Texture { } SetSpellByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 shownMoneyFrames = 1 SetSocketedRelic = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 ProcessInfo = defined @SharedXML/Tooltip/TooltipDataHandler.lua:232 ProcessLines = defined @SharedXML/Tooltip/TooltipDataHandler.lua:289 NineSlice = Frame { } SetInventoryItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 numMoneyFrames = 1 info =

{ } SetLootRollItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetPossession = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetUnitDebuffByAuraInstanceID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetBagItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetPetAction = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetAction = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 TextRight1 = WQT_CompareScrapeTooltip1TextRight1 { } IsTooltipType = defined @SharedXML/Tooltip/TooltipDataHandler.lua:347 SetInventoryItemByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetRecipeResultItemForOrder = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetCurrencyByID = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetVoidItem = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetQuestLogCurrency = defined @SharedXML/Tooltip/TooltipDataHandler.lua:440 SetMerchantCostItem = <func

AlexFolland commented 1 year ago

Thank you so much for posting the errors. I've tried to figure out how to solve them and asked in the WoWUIDev Discord a bit, but it's not trivial and I have to start working soon, so I don't have time to solve it right now. Therefore, I've undone the addition of the tooltip hook and the TOC version increase for now.

@padic-dev It seems IsEquippedItem() is not always (or not ever?) available on the tooltip data. If you're interested in looking into this, there's now tag 2023-01-27-release which has this issue. I may fix it myself soon, but WoW mainline is failing to install on my machine right now and I'm busy for the rest of today and this whole weekend, so I'm not sure when I'll have time to check it.

AlexFolland commented 8 months ago

Since several people have reported the incompatibility with Dragonflight 10.0.2 since the release of Dragonflight 10.0.2, I've decided to start closing all tickets which are essentially duplicates of the first report of this issue, so for this ticket, I'll "close as not planned" because that's what GitHub says to use if a ticket is a duplicate, even though I don't consider resolving this to be "not planned". I appreciate the report and all the discussion nonetheless. Here's the first report ticket: https://github.com/AlexFolland/AutoGear/issues/38

That original report ticket has a comment with an update from me about the status of AutoGear from my perspective, including information about my attempt to fix AutoGear with the API changes introduced by Dragonflight version 10.0.2. Here's a direct link to that comment: https://github.com/AlexFolland/AutoGear/issues/38#issuecomment-1949172287 If you are interested in the status of AutoGear, please read that comment.

TL;DR: I'm back to playing WoW, but it's Classic SOD for now, and I still plan to solve Dragonflight 10.0.2-and-later compatibility some day.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.