search

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping
https://curseforge.com/wow/addons/autogear
Other
8 stars 11 forks source link

Dragonflight compatibility #42

Closed padic-dev closed 1 year ago

padic-dev commented 1 year ago

Alex,

Not sure if you are still actively working to repair this add-on for DragonFlight. I have tried a few times to make this work for my needs and have been updating the issue with my changes. I was able to make a more viable version today and decided to make a pull request for you to review.

No promises it is perfectly working for 10.0.2 but basic gear equipping seems to be working for my needs. I did add some comments where I made changes to help relay why I made the changes I did. Hopefully this helps you and the community who use your add-on.

I did not update the TOC file since this is not a complete fix and it is your add-on to make the decisions on. Also I did not test the changes for Classic or Wrath but I did try to use cross platform logic in most places as I understand it.

-Padic

shot1330 commented 1 year ago

yeah Check this out Alex

AlexFolland commented 1 year ago

I made some changes for compatibility with the current code base and to maintain Wrath Classic compatibility. I tested in-game in Wrath Classic and it seemed to work, so I pushed and tagged the release. Thanks for your effort with this. Ultimately, it came down to 2 necessary changes, along with some changes that were contributed by a different contributor. Would you mind testing this in Dragonflight?

AlexFolland commented 1 year ago

It seems to have exhibited errors immediately, unfortunately, so I've undone it for now until the tooltip issue can be resolved. More info is in #40.