search

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping
https://curseforge.com/wow/addons/autogear
Other
8 stars 11 forks source link

fixed pawn integration #5

Closed josephdouce closed 5 years ago

josephdouce commented 5 years ago

added a chat command to set the spec to anything you want /ag setspec Class: Spec

added a search for the EXACT match in pawn as priority

function AutoGearGetPawnScaleName() now uses the Override Spec if it is enabled

not sure why the diff is so big, somethings messed up there as i only changes about 4 lines

josephdouce commented 5 years ago

example usage

Have a Pawn spec called "Tank" /ag setspec Shaman: Tank /ag scan

equips all tank gear

josephdouce commented 5 years ago

you also need to ass a spec with the correct name to the weightings section in the Lua if you want to sue different names, the standard names works as expected

AlexFolland commented 5 years ago

This is cool. I'd like to check your changes, but the diff is huge because you changed the indentation. Please change the indentation back so I can review the changes clearly.

AlexFolland commented 5 years ago

Thanks for reverting the first one! If you added a commit to change the indentation to all tabs, then another for your changes, that would be perfect for reviewing!

josephdouce commented 5 years ago

all sorted, the issue was the

local spec = AutoGearGetSpec()

doesn't check for override

currently the specs need to named be just "Enhancement" etc in pawn, I can probably sort it to be "Shaman: Enhancement"

josephdouce commented 5 years ago

With regards to a drop down this breaks the macro functionality, the whole idea of this was to be able to macro gear swaps, I'll fix the spelling and do some error checking.

AlexFolland commented 5 years ago

I've implemented a relatively robust command line interface for the setting the spec override. Tomorrow, I'll work on implementing a similar feature for setting Pawn scale, which is separate and not to be mixed with AutoGear's built-in weights. The spec override feature is for AutoGear's weights. Setting the Pawn scale will be done with /ag pawnscale [scale name].

AlexFolland commented 5 years ago

I've implemented all the requested functionality myself, in a way that's compatible with your setup. Please feel free to pull my changes and discard yours. Thank you for the inspiration!