search

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping
https://curseforge.com/wow/addons/autogear
Other
8 stars 11 forks source link

Update please #61

Closed ollyvs closed 3 months ago

ollyvs commented 4 months ago

Update please for Cataclysm Classic

AlexFolland commented 4 months ago

I'm out of the country and not at my usual PC, so I don't have the access or the time right now to write and test an update, but I'd like to do so soon. When I get back some time this month, I should be able to find some time to write and test an update. In the mean time, if you do manage to solve it, please feel free to open a pull request and I'll review and merge it if it looks good. Thanks for your interest!

Also in the mean time, it's possible that I can solve it if you show me the error message. I might be able to write an untested update. No guarantees though, since I haven't had much free time for myself on the PC here while I'm out of the country.

AlexFolland commented 4 months ago

I would like to anticipate what changes will be needed by the time I'm available for solving this. If anyone reading this has time, please install BugSack and BugGrabber, reproduce the error(s), and post the error(s) here, preferably in a collapsible monospace block.

TyThompson commented 4 months ago

Looks like realSpec is being evaluated to numbers and they don't seem to depend on the spec Here are some examples Warlock 865 Druid 748 Warrior 845 Rogue 181

TyThompson commented 4 months ago

Adding realSpec = tostring(realSpec) above

Line AutoGearPrint("AutoGear: Looks like you are a"..(realSpec:find("^[AEIOUaeiou]")....

Can solve the issue temporarily

AlexFolland commented 3 months ago

This should now be resolved. Please test the latest head revision in the master branch in Cataclysm Classic and open a new ticket for any issue you reproduce.

AlexFolland commented 3 months ago

The addon is even more fixed now. I made many changes. Please check it out when you can. By the way, thank you very much in particular for your contributions, @TyThompson.