search

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping
https://curseforge.com/wow/addons/autogear
Other
8 stars 11 forks source link

Bags and rings after the first are not being consider to be equiped as upgrade #63

Closed prot3ct closed 2 months ago

prot3ct commented 3 months ago

Autogear is not equiping items after the first one. For example upgrades for rings are made only for the ring in slot1.

Same is for bags, only first bag is consider for upgrade.

prot3ct commented 3 months ago

image

prot3ct commented 3 months ago

In the image u can see I have 3 netherweave bags and 1 frostweave and the frostweave bag in my inventory wont equip, when doing /ag scan

AlexFolland commented 3 months ago

Do you have slot-locking enabled? If so, do you have any slots marked as locked in the slot-locking dropdown?

prot3ct commented 3 months ago

no its not enabled, and no slots are marked. This bug got introduced after cata pre-patch lunch

AlexFolland commented 3 months ago

The Cataclysm changes are not in a release yet since I haven't seen any testing feedback for them. Are you using the latest git HEAD from the master branch, or just the latest public release, which is an older version?

prot3ct commented 3 months ago

I tried with both and this bug is reproduced on both.

AlexFolland commented 3 months ago

OK, I reproduced an issue and pushed a fix which might also solve your issue. After my fix, I was able to do the following successfully in Cataclysm Classic:

  1. Unequip 2 out of my 4 bags, leaving me with 2 empty slots, a 10-slot bag still equipped, and a 16-slot bag still equipped
  2. Buy a 6-slot bag, leaving me with the following bags in my inventory but not equipped: a 6-slot bag, an 8-slot bag, and a 12-slot bag
  3. Run the AutoGear scan, which then equipped both the 12-slot bag and the 8-slot bag, in that order, resulting in all the bags with slots higher than 6 being equipped, all at once

Can you please try with the latest git HEAD from the master branch and let me know if the issue is resolved or if you can still reproduce it?

prot3ct commented 3 months ago

For me this is not working. Everything is like it was before. I downloaded latest master. Also this bug applies to ring1, ring2

AlexFolland commented 3 months ago

OK, thanks for the info. Since I can't reproduce this on my end, I will need to see the specifics of the circumstances under which the issue manifested for you more clearly to be able to solve this. Using the latest master, can you please reproduce the issue again and show me the following?

prot3ct commented 3 months ago

ok, I will try tonight.

prot3ct commented 3 months ago
image

You can see in the screenshot, I have frostweave bag in my inventory and I dont have bag4 slot equiped at all

prot3ct commented 3 months ago
image

Thats the tooltip of the bag.

You can see that this bag is not being compared to the bag with lowest slots, but just the first one.

I am sorry for the delayed responses. I was on a trip past couple days.

AlexFolland commented 3 months ago

OK. I can see that you don't have the latest version, since I fixed the Pawn debug tooltip info. It should say "Pawn says item can't have stats" beside "Pawn value", not "nil item data". Can you please install the latest version and try again?

prot3ct commented 3 months ago

Latest master doesnt work as well. Here is screenshot image

AlexFolland commented 3 months ago

I did some major refactors which might include fixing this bug. Can you please test again with the latest commit in master as of now? I couldn't reproduce the bug in a lot of testing with bags and empty bag slots, etc., so it may be resolved.

prot3ct commented 3 months ago

Tried with latest master as of now. Bug is still happening everytime.

AlexFolland commented 3 months ago

I'll need more information to figure this out. There's no clear way for this to happen in the code base, so I need the debug info tooltips for all of your bags. I made many changes to the code, so it is useful to see these tooltips with the latest.

By the way, I noticed your screenshots are a little awkward (stretched and such), meaning I expect you're doing something unnecessarily difficult to send these screenshots. An easier way in Windows is to press Super ("Windows" key) + Shift + S to run the snipping tool, drag a rectangle that covers the tooltip, focus the comment box on GitHub, and simply paste from the clipboard (Shift+Insert or Ctrl+V usually). Pasting image data into the GitHub comment box causes your browser to upload the image to GitHub and generate the correct image tag, so you don't have to use any third-party tools or hosts, or write the image tag yourself.

I personally use Flameshot on both Linux and Windows, but the Windows snipping tool and GitHub together get the job done basically.

By the way, this issue is extremely difficult to solve on my own since I can't reproduce it and I feel like I have an even-more complicated situation than you're showing with bag equipping. I want to fix it, but I really need your help since it makes no sense right now.

AlexFolland commented 2 months ago

I've pushed and released another change which might resolve this. Can you please give it a try?

prot3ct commented 2 months ago

I tested with latest master, bug is still present.

I am atatchin screenshots of each bag debuginfo here. image image image image

This bug aplies to ring 2 and trinket 2 as well.

AlexFolland commented 2 months ago

Please use the latest version of AutoGear. I have removed a bag on my end and I see the empty slot as I had fixed after your initial report. If you're not seeing that, you must not be using the latest version of AutoGear, from either CurseForge or GitHub.

image

This shows that AutoGear does see the empty bag slot and sees that it has 0 score.

prot3ct commented 2 months ago

Ok literally tried multiple times with latest master and latest from Curseforge, I am not getting 0 score on this.

AlexFolland commented 2 months ago

I think you must be extracting the addon to the wrong directory or something like that. The behavior in your screenshots does not match the behavior of the latest version. Maybe you're updating the _classic_era_ addons directory and not the _classic_ addons directory.

AlexFolland commented 2 months ago

It's especially telling that you don't have a "soulbinding" line in your debug info. That would not be missing in the latest version. It's been there for 2 weeks now, and you can see it in the code here on GitHub: https://github.com/AlexFolland/AutoGear/blob/238f555cf2a4f35dcf8b1e5a828eab80fec5f27a/AutoGear.lua#L4371

prot3ct commented 2 months ago

Ok, my bags with soulbiding, thats latest master for sure, I double-checked.

image image image image

AlexFolland commented 2 months ago

Thanks for updating. I still can't reproduce this, even with all other addons disabled. Can you please disable all other addons and try again, including an /ag scan with the bag not equipped?

AlexFolland commented 2 months ago

I committed some changes which should give more information in the tooltip for bags, especially with empty bag slots. Can you please get the latest changes from the master branch and try it, then paste screenshots here?

AlexFolland commented 2 months ago

I fixed another issue which may have caused this behavior yesterday and released the fix. I think this must now finally be resolved, so I'm closing the ticket now. Please let me know if you can still reproduce this and I'll reopen the ticket. Thanks for your report and your consistent responses.