When using "weapon and shield" one-hand weapons score arent not calcualted properly

AlexFolland / AutoGear

WoW convenience addon that automatically handles gear looting and equipping

https://curseforge.com/wow/addons/autogear

Other

8 stars 11 forks source link

When using "weapon and shield" one-hand weapons score arent not calcualted properly #66

Closed prot3ct closed 2 months ago

prot3ct commented 2 months ago

I am using "weapon and shield" in Autogear. When I do /ag scan, score of one-hand weapons is not calculated properly, only main-hand are evaluated properly. in Cata there are barely main-hand weapons and its super annoying.

AlexFolland commented 2 months ago

Thanks for the report. I haven't seen this and don't have a simple way to reproduce it here, so please enable /ag debuginfo and then show me screenshots of the following:

your AutoGear options menu
the tooltips for all relevant main hand and one hand items; especially the ones you are seeing the issue with

Doing this will help me investigate what AutoGear might be doing that I haven't seen before.

FYI, you can paste images (like cropped screenshots) directly from your clipboard into GitHub messages for convenience.

Sorry for asking for this, but I do want to help you and all other users in the same scenario, but don't have the particular scenario you're in or enough time to create the scenario here on my end. I appreciate your help with screenshots like this tremendously.

prot3ct commented 2 months ago

Screenshot 1 is one-hand Screenshot 2 is main-hand

You cann see gray main-hand has better score, which is strange.

prot3ct commented 2 months ago

This is Protection Paladin and weapon type value in code is "weapon and shield"

AlexFolland commented 2 months ago

Please use the latest version of AutoGear. From your other bug report, I have seen that you are not using the latest version, from either GitHub or CurseForge. The logic related to this report has been changed in the weeks since you've last updated.

prot3ct commented 2 months ago

Right before marking these screenshots I downloaded lastest master from github. I just tried again and debuginfo shows same numbers. Are you sure you pushed those changes?

AlexFolland commented 2 months ago

Yes. Please make sure you have extracted the addon to the correct location, or just use the release from CurseForge with an addon manager like WowUp-CF which can install addons from CurseForge in the correct directory.

AlexFolland commented 2 months ago

Your screenshots do not have the "soulbinding" line that's been in the latest version for 2 weeks now, and multiple releases. You can see that line in the code here, already on GitHub: https://github.com/AlexFolland/AutoGear/blob/238f555cf2a4f35dcf8b1e5a828eab80fec5f27a/AutoGear.lua#L4371

prot3ct commented 2 months ago

Here are both weapons, One handder has much lower score while stamina and strength are top score stats. I trie to find main-hand with same stats, but the score difference is quite big I assure its not cus of the different stats.

AlexFolland commented 2 months ago

Thanks for the screenshots and furthering the report. Although I have changed the logic in the latest version and you are still not using the latest version in these screenshots, this does look like it could be an issue in the latest version, although I'll need to investigate myself why it might be. These items have the same item class ID and item subclass ID as each other, so they should be treated identically, but maybe they're not being. While I investigate this and try to figure it out, please test with the latest version.

Also, please fix your screenshot methodology as suggested in the other ticket. There is no reason to use such stretched screenshots.

AlexFolland commented 2 months ago

Also, what are your settings? Do you have any locked slots?

AlexFolland commented 2 months ago

OK, I tried my best to reproduce this, but couldn't. My protection warrior was also using "weapon and shield" weapon type along with Pawn scoring.

I can see by looking at the "Pawn value" line in your debug tooltips (which is a number that comes directly from Pawn) that the wrong scoring comes directly from Pawn. I expect that your stat weights are wrong in Pawn. Please update Pawn and fix your stat weights so that it doesn't have extra weight for "one hand" items over "main hand" items.

AlexFolland commented 2 months ago

I'm going to close this one. It is a Pawn issue. If you disagree, please feel free to show me your stat weights and settings and explain why.

AlexFolland commented 2 months ago

By the way, I investigated this on my warrior just to re-confirm and I found the issue in Pawn. See here:

Pawn's default tank scales right now have "main hand" weights and not "one hand" weights, so they are pretty broken.