search

AlexGalays / abyssa-js

Framework agnostic hierarchical router for single page applications
MIT License
71 stars 9 forks source link

Issue #23 : cutomize hashbang #28

Closed pauldijou closed 10 years ago

pauldijou commented 10 years ago

And some minor stuff...

AlexGalays commented 10 years ago

Looks fine except for a small naming issue: Since the ! comes after the # it should be called postfix or suffix, not prefix :)

pauldijou commented 10 years ago

For me, the hash is the whole stuff after the # (here it is the full pathQuery). That's why you set location.hash = url;. But now you can prefix it and the code clearly do that by inserting the option before the rest of the hash: location.hash = options.hashPrefix + url;.