search

AlexGustafsson / homebridge-wol

A Wake on Lan plugin for Homebridge
MIT License
301 stars 30 forks source link

Quality Assurance Beta #13

Closed AlexGustafsson closed 7 years ago

AlexGustafsson commented 7 years ago

I've decided to do a complete code refactor to hopefully provide better readability of the code with a stricter code standard. I've also decided to try to remove the dependency on net-ping which used raw sockets to provide ping functionality. Instead ping is introduced which relies on the native implementations of pinging. This should remove the need for sudo permission on linux devices or at least mitigate the issue to a complete linux one where the fix is to provide the user running Homebridge with rights to ping.

All in all these changes should provide easier navigating of the code as well as improved usability in the sense that sudo rights should no longer be required.

Before the changes is pushed to the master branch as well as published to npm I'd like some feedback to see that it is working reliably on devices.

To install and test the beta, navigate to the beta branch and follow the instructions.

blubber commented 7 years ago

A pull request would make it much easier to review the changes.

AlexGustafsson commented 7 years ago

As @blubber suggested, I've opened a PR to make the changes easier to review. See #14.

AlexGustafsson commented 7 years ago

Merged.