fl.window~ /window parameter has inconsistent casing between kebab and snake

AlexHarker / FrameLib

A library for arbitrary-rate arbitrary-size frame processing

BSD 3-Clause "New" or "Revised" License

74 stars 9 forks source link

fl.window~ /window parameter has inconsistent casing between kebab and snake #68

Closed jamesb93 closed 4 years ago

jamesb93 commented 4 years ago

For illustrative purposes:

nutall_continuous
flat-top
blackman-harris

Although not a huge deal I think the casing of these is not right.

it should be:

flat_top
blackman-harris

I believe flat top is two separated words in the literature whereas blackman-harris is hyphenated anyway. This makes blackman-harris the only hyphenated one which is a little stylistically weird to code around but more correct in terms of the word itself.

AlexHarker commented 4 years ago

I do appreciate you looking at this, but this object is mid review and I'm aware of this issue and I need to make a decision on this and various other things in the window object - the difference is partly there so I don't forget.

jamesb93 commented 4 years ago

Yes sorry. I am coming across things as I update old help files and Max Documentation. Take these issues as friendly reminders that I've seen things which may or may not be of concern to you.