search

AlexHex7 / Non-local_pytorch

Implementation of Non-local Block.
Apache License 2.0
1.57k stars 277 forks source link

3D pooling #17

Closed protein27 closed 5 years ago

protein27 commented 5 years ago

https://github.com/AlexHex7/Non-local_pytorch/blob/589dde8cc048b2e963cdd3e06f96f7ef20130dcf/lib/non_local_simple_version.py#L59

In the paper, the pooling is only in the spatial domain. I think the kernel size is not set correctly when the input contains temporal dimension.

https://github.com/facebookresearch/video-nonlocal-net/blob/b273c446e8e10dbaec266520e4005d27d7052125/lib/models/nonlocal_helper.py#L40

AlexHex7 commented 5 years ago

@protein27 Thanks for pointing it out! I will correct it when I have time.

AlexHex7 commented 5 years ago

I have corrected the code .