search

AlexIIL / LibBlockAttributes

Library mod for fabric that adds items and attribute API's for blocks.
Mozilla Public License 2.0
43 stars 12 forks source link

ConstantItemFilter throws on testing against an empty stack, and no other ItemFilter does #12

Closed LemmaEOF closed 4 years ago

LemmaEOF commented 5 years ago

ConstantItemFilter has a throw when the passed ItemStack is empty. This would be all fine and good, since the javadocs for ItemFilter say to do this, but no other built-in item filter follows this behavior. I don't think that throwing when testing an empty stack like this is a good idea, but whether it really should or not, it should be consistent across all built-in filters to avoid confusion.

AlexIIL commented 4 years ago

I changed this behaviour a while ago and forgot to comment, woops.