search

AlexIIL / LibNetworkStack

Mozilla Public License 2.0
11 stars 2 forks source link

Fix CoreMinecraftNetUtil attempting to load client-sided classes #12

Closed Kneelawk closed 1 year ago

Kneelawk commented 2 years ago

This PR

This pull-request fixes an issue where CoreMinecraftNetUtil would attempt to load client-sided classes on a dedicated-server.

Testing

I have tested this patch on a dedicated server with Wired Redstone and have found that it fixed the issue.

Related Issues

This was first mentioned in: https://github.com/Kneelawk/WiredRedstone/issues/10

Kneelawk commented 2 years ago

This is a simple fix. However, a better solution might be to refactor CoreMinecraftNetUtil into common and client classes so as to make sure no client-sided classes get loaded on a dedicated-server.

Kneelawk commented 1 year ago

This PR is good enough for now and I don't really have time to work on the full refactor for this at the moment.