AlexIIL / SimplePipes

A small test pipes mod based around LibBlockAttributes
Mozilla Public License 2.0
32 stars 14 forks source link

[MC 1.15.2 - SP 0.3.4] Possible Blocks Conflict #36

Closed Dragonsissiy closed 4 years ago

Dragonsissiy commented 4 years ago

Hello again!

As I said on the mod page on curse, since installing this mod, it seems to conflict with Tech Reborn and Blockus in terms of shared blocks. (If I remember right from build craft they share some ores and in blockus's case, asphalt and a few others.) There are no crashes yet, but the ores from Tech Reborn are missing in the REI menu as well as in creative mode's menu. I'll list my entire mod list and the screenshots I took. I will also let the other mod owners know in case it ends up being a collaborative effort. I appreciate the time you take to work on these mods as I know you also have a life outside of minecraft. :3 Please let me know if there is anything else I can help with.

CurrentModsList

LookingAtMCIron

LookingAtTR_TinOre

LookingAtBlockus_Random

LookingAtBlockus_OrangeAsphalt

LookingAtMenu_MissingBlocks

LookingAtMenu_MissingBlockusBlocks

Thank you!

Dragonsissiy commented 4 years ago

Oh and only reason I even have the ores there, is because I already had them on my character on my server. When I search for them they no longer show up.

Dragonsissiy commented 4 years ago

Realized my REI was out of date, updated it to the most recent one v3.3.18 and still have the same issue.

Dragonsissiy commented 4 years ago

Just wanted to clarify that when Simple BC Pipes is not installed all other blocks from the other mods return.

AlexIIL commented 4 years ago

After some debugging it turns out this is an issue with how SimplePipes scans blocks for facades - essentially it scans the block just after it is registered (but before the item is registered) and calls Block.asItem(), which then looks up the item to find... nothing. It then caches nothing for next time (woops) and then the correct item is registered.

Dragonsissiy commented 4 years ago

After some debugging it turns out this is an issue with how SimplePipes scans blocks for facades - essentially it scans the block just after it is registered (but before the item is registered) and calls Block.asItem(), which then looks up the item to find... nothing. It then caches nothing for next time (woops) and then the correct item is registered.

I'm glad the issue has been found! I wish I understood more about modding to better help with my explanations lol. Thank you so much for looking into this so quickly. :D

AlexIIL commented 4 years ago

Ok, this has been fixed in 0.3.5.