search

AlexIIL / SimplePipes

A small test pipes mod based around LibBlockAttributes
Mozilla Public License 2.0
32 stars 14 forks source link

0.9.x 1.19.3+ texture + model changes #68

Closed mvacoss closed 3 months ago

mvacoss commented 1 year ago

SimplePipes-0.9.x-1.19.3-fix.zip

More information in my fork

Kneelawk commented 1 year ago

Hi! Thank you for contributing.

I'll admit, I don't really understand what the purpose of this PR is. I tried extracting the zip you gave into a repository branch and I see a number of changes, mainly to textures and the height of the tank. It would be helpful if you could describe what you intend to do with this PR.

Also, it would be helpful if you could fork this repository and then use that fork as the source of your changes. Then, when you're ready to contribute your changes back, you could make a PR from that repository. That way the PR change list would accurately show your changes.

Thank you.

Kneelawk commented 3 months ago

I'm going to close this, as the from branch is broken and it doesn't appear there is a way to fix it. Feel free to open a new PR with a fixed from branch.