search

AlexKMDev / WebRTC

Unofficial builds of Google WebRTC iOS Framework
https://webrtc.org/native-code/ios/
Other
292 stars 76 forks source link

Wrong version naming? #20

Closed bmaslakov closed 7 years ago

bmaslakov commented 7 years ago

The latest release at this repository is 56.10.15101, but as far as I understand it should be 56.10.15644. Please see the commit at googlesource, it clearly states that Cr-Commit-Position is refs/heads/master@{#15644}.

bmaslakov commented 7 years ago

Ok, I see you're using Cr-Branched-From for the revision number and I was referring to Cr-Commit-Position. I guess your approach is better.

AlexKMDev commented 7 years ago

I just follow stable branch naming in that case, not master one, i.e. <branch number>.<update number>.<revision number>. I thought that commit under revision 15644 just was cherry-picked from master to 56 branch, so the original revision still 15101, but with 10 cherry-picked commits from master.

bmaslakov commented 7 years ago

Yep, you're right. I just got confused when I saw that revision number is not incremented for hotfixes.