Bitcode is now supported in version 57

AlexKMDev / WebRTC

Unofficial builds of Google WebRTC iOS Framework

https://webrtc.org/native-code/ios/

Other

292 stars 76 forks source link

Bitcode is now supported in version 57 #21

Open jondwillis opened 7 years ago

jondwillis commented 7 years ago

./tools-webrtc/ios/build_ios_libs.sh -e !

AlexKMDev commented 7 years ago

The compiled framework still doesn't contain bitcode:

/V/H/w/s/out_ios_libs> otool -l WebRTC.framework/WebRTC | grep __LLVM
/V/H/w/s/out_ios_libs>

jondwillis commented 7 years ago

Please see http://stackoverflow.com/a/33105733/127422

It indeed does contain bitcode :) I am able to use my build of latest WebRTC master with bitcode enabled in my app.

otool -arch armv7 -l WebRTC.framework/WebRTC | grep LLVM    
  segname __LLVM
  segname __LLVM

jondwillis commented 7 years ago

We should update the README if this gets applied and verified.

antoniotuzzi commented 7 years ago

Are you getting a 700MB library when compiled bitcode ON ?

jondwillis commented 7 years ago

@antoniotuzzi Yeah, trying to figure out why.

antoniotuzzi commented 7 years ago

@jondwillis compiled static is 776MB must be related to the huge number of .obj linked: the bitcode should be doing very strange tricky things with this sizes is impossibile to distribute in an SDK anyway, when compiled in a final product, or intermediate library, size decrease A LOT

jondwillis commented 7 years ago

@antoniotuzzi I have noted the large framework size in https://bugs.chromium.org/p/webrtc/issues/detail?id=5085&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20ReleaseBlock%20Component%20Status%20Owner%20Summary&groupby=&sort=

I will update here if there is an answer.

wenxin3262 commented 7 years ago

I don't like bitcode, hard to manage dSYMs for little benefits

fuxx commented 7 years ago

Bitcode doesnt change anything on symbolification of crash logs. apples / testflight gives you the correct dsyms if they recompile form source.