AlexKhymenko / ngx-permissions

Permission and roles based access control for your angular(angular 2,4,5,6,7,9+) applications(AOT, lazy modules compatible
MIT License
936 stars 126 forks source link

Set NgxPermissionsGuard functions to protected access levels #220

Closed joelghill closed 1 year ago

joelghill commented 1 year ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ x] Feature request
[ ] Documentation issue or request

Current behavior

I'm trying to extend the behavior of the NgxPermissionsGuard in a project to fit a custom use case. I'd like to be able to create a new class that extends NgxPermissionsGuard and overwrite some of the methods to better meet my needs.

Expected behavior

I would expect that some, if not all, of the private internal methods used by NgxPermissionsGuard would be marked as protected. This would allow certain behaviors to be overwritten or extended by people consuming the library.

Environment


Angular version: 15.1
ngx-permissions version: 15.0
            
AlexKhymenko commented 1 year ago

@joelghill available in 15.0.1

joelghill commented 1 year ago

Thank you!