AlexKnauth / hollowknight-autosplit-wasm

A cross-platform autosplitter for Hollow Knight that supports Windows, Mac, and Linux
MIT License
5 stars 0 forks source link

Make sure "detect manual start" doesn't think its a start when the timer's been running but i just got set to 0 #22

Closed AlexKnauth closed 9 months ago

AlexKnauth commented 9 months ago

While testing for KilledOblobbles in asr-debugger, I encountered a problem with the manual start detection:

I had ColosseumSiverEntry as a start-triggering autosplit, and then KilledOblobbles, and then ColosseumSilverExit as an end-triggering autosplit.

I killed the Oblobbles and exited Colo 2, and it split both of those correctly, but, since it was asr-debugger and that doesn't know how many splits there are supposed to be, the asr-debugger timer state was still Running, not Ended, but the autosplitter's internal i was at 0.

Currently when the autosplitter sees i at 0 and the timer in Running, it thinks that's from a manual start, but in this case that's wrong because it had been Running the whole time. It should only be a manual start if the timer had been in Ended or NotRunning before, and then changed to Running.