Displays hits 0 when timer Ended and not yet reset

AlexKnauth / hollowknight-autosplit-wasm

A cross-platform autosplitter for Hollow Knight that supports Windows, Mac, and Linux

MIT License

5 stars 0 forks source link

Displays hits 0 when timer Ended and not yet reset #70

Closed AlexKnauth closed 5 months ago

AlexKnauth commented 5 months ago

For example on this screenshot, below the splits saying "Hollow Knight 38 -8 0:38" and above the big blue "38", it says "hits 0" when it should say "hits 38", until reset.

Hollow-Knight-Any%-Shade-Soul-Route-in-58m-47s-splits

AlexKnauth commented 5 months ago

Get rid of assumptions that i = 0 means timer state should be NotRunning.

An i of 0 means one of:

NotRunning
Ended but with auto-reset turned on so it's ready to query the auto-start code and reset and start at the same time when that says a new run has started

Regexp search: [*i0]+[ <=>]+[*i0]+

AlexKnauth commented 5 months ago

Add a new test for when the user resets from Ended to NotRunning while i remains 0 the whole time. That is when the auto-hit-counter should reset, not a moment before.