AlexKnauth / hollowknight-autosplit-wasm

A cross-platform autosplitter for Hollow Knight that supports Windows, Mac, and Linux
MIT License
5 stars 0 forks source link

Don't split too early on quit-outs: GruzMother, DreamGate, UnchainedHollowKnight #78

Closed AlexKnauth closed 4 months ago

AlexKnauth commented 5 months ago

During quit-outs, certain splits sometimes split too early.

When the game starts up, before it gets to the main menu, the PlayerData appears to include these unexpected values:

PlayerData hasDreamGate: true
PlayerData maxHealthBase: 4
PlayerData killedBigFly: true
PlayerData unchainedHollowKnight: true

Then, on some quit-outs, but not all, the game seems to go back to those unexpected values during the quit-out.

So it may sometimes wrongly split DreamGate, GruzMother, or UnchainedHollowKnight during a quit-out.

I've seen this happen with the existing auto-splitter with DreamGate, and I've heard from menmoe that it's been happening with GruzMother on 1221 as well.

Perhaps there should be an extra GameState Playing condition on these splits that this problem has been observed for, and not just on the Menu versions of these splits. Like, don't just fix MenuDreamGate (and MenuGruzMother if that existed), fix DreamGate and GruzMother themselves too.