search

AlexLazcano / Pink4Thursday

0 stars 0 forks source link

Alex colors #14

Closed AlexLazcano closed 3 years ago

AlexLazcano commented 3 years ago

Refactored to use styled components in RecentActivity and in ActiveDiscussion component, Implemented theme provider and replaced Global styles with theme.js. I will delete global styles after I make sure it's not used somewhere else. Might be able to place theme provider in a higher component. I separated the routes in the BottomNavBar to be their own files

AlexLazcano commented 3 years ago

@jake-pauls I meant to merge this to develop lol. So I will change that. As for prettier, yeah that sounds good! I can also install husky so that it auto does it when we commit. Might be good to use prettier and standard js. Standard js make it a lot cleaner like it won't let you commit if there are unused imports and stuff like that. Let me know what you think

jake-pauls commented 3 years ago

@jake-pauls I meant to merge this to develop lol. So I will change that. As for prettier, yeah that sounds good! I can also install husky so that it auto does it when we commit. Might be good to use prettier and standard js. Standard js make it a lot cleaner like it won't let you commit if there are unused imports and stuff like that. Let me know what you think

Sounds great. Up to you about merging into development or main! Like I mentioned in the other PR the branching strategy is totally up to you.

AlexLazcano commented 3 years ago

@jake-pauls I meant to merge this to develop lol. So I will change that. As for prettier, yeah that sounds good! I can also install husky so that it auto does it when we commit. Might be good to use prettier and standard js. Standard js make it a lot cleaner like it won't let you commit if there are unused imports and stuff like that. Let me know what you think

Sounds great. Up to you about merging into development or main! Like I mentioned in the other PR the branching strategy is totally up to you.

How about we merge what we have into develop, then merge develop into main, then we can start branching off from that. Also, thoughts on releasing before merging whenever we merge changes?

jake-pauls commented 3 years ago

@jake-pauls I meant to merge this to develop lol. So I will change that. As for prettier, yeah that sounds good! I can also install husky so that it auto does it when we commit. Might be good to use prettier and standard js. Standard js make it a lot cleaner like it won't let you commit if there are unused imports and stuff like that. Let me know what you think

Sounds great. Up to you about merging into development or main! Like I mentioned in the other PR the branching strategy is totally up to you.

How about we merge what we have into develop, then merge develop into main, then we can start branching off from that. Also, thoughts on releasing before merging whenever we merge changes?

Sure, if you merge this into development it should update my outgoing PR. Not sure I understand your other question. Feel free to DM me about it if it's easier. 🙂