search

AlexMNet / MMM-TheSpaceDevs

Magic Mirror Module serving Rocket Launch data based on TheSpaceDevs API
MIT License
1 stars 1 forks source link

Review #8

Closed KristjanESPERANTO closed 1 month ago

KristjanESPERANTO commented 1 month ago

I did a little review and have these change suggestions. There are no functinal changes :slightly_smiling_face:

I introduced the package.json file to get keywords for the new module list.

AlexMNet commented 1 month ago

@KristjanESPERANTO Thank you for you PR I will review as soon as I have some time. 🙂

The core of this module actually comes from the MMM-SpaceLaunchNow module by koxm that is no longer working. (It may be safe to remove that from the list now as this module replaces that) I got permission from the creator to use his module and create a new one from it. I essentially used the existing repo as a starting point. I have made a lot of changes and added new features but still have some more work to do in terms of updating some of the legacy code and maybe adding a few more features I have been thinking about.

Thanks again for the suggestions and help!

KristjanESPERANTO commented 1 month ago

Sounds good! :+1:

I just moved MMM-SpaceLaunchNow to the "outdated" section.