AlexModGuy / AlexsCaves

82 stars 41 forks source link

Tectonic mod not compatible with Alex's Caves #794

Open Apocalyptichobo opened 7 months ago

Apocalyptichobo commented 7 months ago

It seems like all different types of caves (especially Abyssal Chasm) don't work very well with the biome generation of the Tectonic mod. They all technically appear, but the underground rivers of lava usually remove all acid in that cave in favor of lava and in general causes some odd terrain gen. Abyssal Chasms don't spawn at all for the most part, except for the structures that accompany the usual cave. I've tested this quite a few times with other mods, no mods (just Tectonic), and with various seeds/world sizes.

Is there a way to change the depth at which the caves generate to be compatible with tectonic? Or, would it be possible to give a priority generation order to the caves over other generation?

AlexModGuy commented 6 months ago

Is it possible to raise this issue to the Tectonic devs so they can add a biome tag to exclude such features such as lava rivers from?

Apocalyptichobo commented 6 months ago

Can you explain more on to what you mean by this? I am trying to learn world gen and attempt to fix it myself but it is slow going. Something like Lithostitched might work to help with this.

SanguineWaters commented 6 months ago

I've posted this issue on their GitHub and it will not be fixed because they would have to change the lower sea floor level back to normal to fix it from their end. Because it is a feature of the mod, they will not change it. However there is a fix in which it will generate the biome more often, but it is not perfect. The abyssal chasm map will be semi-inaccurate, some of the structures will spawn outside of the abyssal chasm on the regular ocean floor, and terrain and structure placement in the biome is not perfect, however I am more than happy it will generate more often. The way to fix is is to change the depth config to be lower. As for the lava river, I have not seen any issues with them. Here's the link if you want to have a look: https://github.com/Apollounknowndev/tectonic/issues/95

Steps: %appdata% .minectraft -> config -> alexscaves_biome_generation -> abyssal_chasm Change to the config below "depth": [ 0.1, 1.2 Do some testing to to fit your needs or improve it, this was a random first try for me.

Apocalyptichobo commented 6 months ago

I find that pretty much all of the biomes except for the primordial caves appear to generate very oddly with tectonic, not just the abyssal chasms. I get that is because of depth but I'm wondering if there is a way to stop or block tectonic cave gen from happening with Alex's it would work

deadspidervenom commented 5 months ago

Is it possible to raise this issue to the Tectonic devs so they can add a biome tag to exclude such features such as lava rivers from?

I do believe several of the issues is Alex's Caves

The reason being before i installed the bellow mod a lot of the caves were not generating right like this, after i did they generate wonderfully. Except for "Abyssal Chasm", which the mod does not add a compat layer for.

https://www.curseforge.com/minecraft/mc-mods/tact

Here is a screenshot showing the mentioned "Toxic Caves" generating with "tectonic + terralith" image

Apocalyptichobo commented 5 months ago

Is it possible to raise this issue to the Tectonic devs so they can add a biome tag to exclude such features such as lava rivers from?

I do believe several of the issues is Alex's Caves

The reason being before i installed the bellow mod a lot of the caves were not generating right like this, after i did they generate wonderfully. Except for "Abyssal Chasm", which the mod does not add a compat layer for.

https://www.curseforge.com/minecraft/mc-mods/tact

Here is a screenshot showing the mentioned "Toxic Caves" generating with "tectonic + terralith" image

I did notice that Alex's Caved were apart of the problem unfortunately. The TACT mod adds the following: Added all Alex's Cave biomes to minecraft:is_overworld tag for compatibility with other mods and datapacks.

Added Forlorn Hollows, Magnetic Caves, Primordial Caves, and Toxic Caves to forge:is_cave for better mod compat.

If this isn't supposed to be how it is in the caves mod I do understand but I've noticed that they do generate much better. As for Abyssal Chasm I do not think there is a workaround but I have downloaded a dimension mod that is just the ocean that I added that biome to with a datapack, which is a pretty good workaround.

deadspidervenom commented 5 months ago

Is it possible to raise this issue to the Tectonic devs so they can add a biome tag to exclude such features such as lava rivers from?

I do believe several of the issues is Alex's Caves The reason being before i installed the bellow mod a lot of the caves were not generating right like this, after i did they generate wonderfully. Except for "Abyssal Chasm", which the mod does not add a compat layer for. https://www.curseforge.com/minecraft/mc-mods/tact Here is a screenshot showing the mentioned "Toxic Caves" generating with "tectonic + terralith" image

I did notice that Alex's Caved were apart of the problem unfortunately. The TACT mod adds the following: Added all Alex's Cave biomes to minecraft:is_overworld tag for compatibility with other mods and datapacks.

Added Forlorn Hollows, Magnetic Caves, Primordial Caves, and Toxic Caves to forge:is_cave for better mod compat.

If this isn't supposed to be how it is in the caves mod I do understand but I've noticed that they do generate much better. As for Abyssal Chasm I do not think there is a workaround but I have downloaded a dimension mod that is just the ocean that I added that biome to with a datapack, which is a pretty good workaround.

could you send me that please?

Work around would be i think like "forge:is_cold_ocean" as the locate command brings me to the cold ocean if the biome does not generate right.

TelepathicGrunt commented 5 months ago

The fix imo is if tectonic is present, Alex’s Caves should adjust the Abyss Chasm’s biome parameters to a new set of parameters that spawns at the full height of the ocean. Right now, tectonic changed how the noise generator generates values throughout the world. As a result, the Abyss Chasm is only spawning at world bottom and unable to make it all the way up to the ocean’s bottom because normal ocean biomes are considered “closer” to the spot’s noise value at surface of oceans.

It is incredibly unlikely that tectonic will change their entire noise generator values for a single mod since that is incredibly difficult to fine tune and get the world working without breaking something else. It’ll be easier for Alex’s Caves to have two sets of biome parameters to use and switch which one to use based on which worldgen mod is present

To be clear, TACT has zero impact on this and is not involved. You will see issue even without TACT

rafaelkai commented 2 months ago

Any news on this issue being fixed?