Citadel is responsible for a signifficant worldgen slowdown

[bravoso]

After creating hundreds of modpacks, i was able to confirm via VisualVM and gameplay that citadel causes massive worldgenlag. In some cases, i've seen over 50% slowdowns.

How to test it:

• Install a few hundreds of mods, citadel and one of it's supported mods.
• Use chunky to pregen the world with citadel and without it.

In my tests, i've seen worldgen with it go about 12-15cps, while without it's near 30cps on 1.18.2 and 1.19.2.

I'm willing to contribute with more information if the developer is willing to investigate it

Screenshot of the benchmark in a 300+ modpack in 1.18.2 with citadel, alex mobs and ice and fire:

Same benchmark without citadel, ice and fire and alex mobs:

[bravoso]

In 1.16.5 there is also a slow-down, but it seems minor compared to 1.17+.

I'm reporting this in a constructive way for the author, since after 1.17 updates, mojang already shrewd up the worldgen performance by less than half.

[soup587]

bumping this, i've noticed it seemingly getting worse over time

mods that can generate many chunks at a time (i.e cracker's wither storm mod) absolutely destroy server tps because most of the server's tick time is spent trying to generate chunks

[InsaanNotFound]

@AlexModGuy