A Library containing shared code used throughout most of my projects. Can be considered a continuation of LLibrary, of which this borrows the majority of its source code from.
Currently, surface rules are merged once per NoiseBasedChunkGenerator instance, ignoring any change in the original value. However, this becomes an issue when another mod modifies NoiseGeneratorSettings.surfaceRules after mergedSurfaceRule has been calculated, as its changes never take effect.
For reproduction steps, see
Sinytra/Connector#149
The solution
Rather than keeping the first calculated mergedSurfaceRule forever, we re-run this calculation every time the input rules change. This ensures the merged rules will always be up to date and compatible with other mods that might modify them.
The issue
Currently, surface rules are merged once per
NoiseBasedChunkGeneratorinstance, ignoring any change in the original value. However, this becomes an issue when another mod modifiesNoiseGeneratorSettings.surfaceRulesaftermergedSurfaceRulehas been calculated, as its changes never take effect.For reproduction steps, see
The solution
Rather than keeping the first calculated
mergedSurfaceRuleforever, we re-run this calculation every time the input rules change. This ensures the merged rules will always be up to date and compatible with other mods that might modify them.Fixes Sinytra/Connector#149