search

AlexModGuy / Citadel

A Library containing shared code used throughout most of my projects. Can be considered a continuation of LLibrary, of which this borrows the majority of its source code from.
24 stars 28 forks source link

Citadel's Checking Update Makes Server Starting Up Really Time-costing. #145

Open Subilan opened 5 months ago

Subilan commented 5 months ago

Currently I'm running a server with over a hundred mods installed, and Citadel is among them, installed as a dependency. Due to some reason the server cannot reach (or takes a hell long time to reach) many remote websites including GitHub, CurseForge, and more. This is not the point as Internet issues arise all the time, but there is no reason for some update check to block the whole process of server starting isn't it?

image

Based on the screenshot above and many similar "10-minute time stops" followed by Citadel's "Connection Reset" error message presented in logs, I assume that Citadel is exactly what to be blame.

It's pretty disappointing to see the server taking 10 extra minutes (guess it's some kind of timeout, which makes the duration between the two log lines in the screenshot so strangely precise) to boot. This means whenever the server crashes and tries to start, it must firstly take 10 minutes to wait for something that is bound to fail to fail. What a pain in the ass.

Why don't I just turn off the update check? I can't. There is none (please let me know if there is already a switch somewhere, or some other way to get rid of it).

Could you please add the switch for update check?

Subilan commented 5 months ago

I managed to fix this on my own. Please check https://github.com/seatitanium/citadel-fix-conn if you find this kind of fix useful.