AlexModGuy / Citadel

A Library containing shared code used throughout most of my projects. Can be considered a continuation of LLibrary, of which this borrows the majority of its source code from.
24 stars 29 forks source link

Radium causes mob's models to stop updating when they are equipped with items #168

Open BabblingFishes opened 2 months ago

BabblingFishes commented 2 months ago

This is a crosspost from Radium's issue tracker, as I'm not sure who is the main culprit. It looks like a mixin conflict.

Both "Ice & Fire" and "Rats" mobs can be equipped with items that change their model. (For example, dragons can wear armor, and rats can be turned into living carrots.) When Radium is installed, these models do not update correctly. The first item added will update the model, but if that item is removed or if a second item is added, the model does not visually change.

The instructions below will be for Ice & Fire, as it is quicker to reproduce.


Version Information

Expected Behavior

When dragons are equipped with armor, it should be visible (and it will look like their inventory preview).

Actual Behavior

The first piece of armor is immediately visible. After that, all other armor is invisible, and the first piece of armor cannot be (visually) removed except by closing and reopening the world.

Reproduction Steps

  1. Spawn in and tame a dragon (a spawn egg and Creative Dragon Meal is a quick way to do this).
  2. Shift+right click to access the dragon's inventory.
  3. Equip any piece of Dragon Armor to the dragon.
  4. Unequip the dragon's armor, or equip a different piece of armor to any slot. This will update the inventory preview, but not the actual dragon.

Other Information

This is fixed by setting mixin.entity=false in lithium.properties, but changing any (or all) of Radium's entity sub-settings to false does not fix the issue.