search

AlexModGuy / Citadel

A Library containing shared code used throughout most of my projects. Can be considered a continuation of LLibrary, of which this borrows the majority of its source code from.
25 stars 29 forks source link

Console error spam NPE #42

Open amoooooo opened 3 years ago

amoooooo commented 3 years ago

I get TON of console error spam from Citadel, all of it is a NPE at com.github.alexthe666.citadel.server.entity.datatracker.EntityProperties.getEntity and com.github.alexthe666.iceandfire.entity.props.ChainEntityProperties.loadNBTData(

full error: https://hastebin.com/uhujurekoc.apache

laneyfamily commented 3 years ago

Getting the exact same thing, each time it seems to correspond with a lag spike as well

Elec0 commented 3 years ago

I'm also getting it, as a server crash.

https://pastebin.com/UVhyZVeN

Darkmega18 commented 3 years ago

raises hand also, I also think I have a crash in relation to it too when it interacts with villagers being customized by Custom villager trades mod, cause theres just a lot of the nulls firing in the latest.log just before they happen, with large amounts of lag happening also.

it seems to be relating to villages in my case. I get large amounts of large around villages and it's constantly popping up. 230k lines worth of it. probably every tick for every villager.

Graftax commented 3 years ago

I am also getting what appears to be the same log spam. I cannot paste my whole log as its too big, but the following error is repeated hundreds of times. If asked I can try to host the log somewhere else.

[26Jul2021 13:41:03.711] [Render thread/FATAL] [net.minecraft.util.concurrent.ThreadTaskExecutor/]: Error executing task on Client java.lang.NullPointerException: null at com.github.alexthe666.citadel.server.entity.datatracker.EntityProperties.getEntity(EntityProperties.java:63) ~[citadel:1.7.2-1.16.5] at com.github.alexthe666.iceandfire.entity.props.ChainEntityProperties.loadNBTData(ChainEntityProperties.java:54) ~[iceandfire:2.1.8-1.16.5] at com.github.alexthe666.citadel.server.entity.datatracker.EntityProperties.loadTrackingSensitiveData(EntityProperties.java:112) ~[citadel:1.7.2-1.16.5] at com.github.alexthe666.citadel.ClientProxy.handlePropertiesPacket(ClientProxy.java:126) ~[citadel:1.7.2-1.16.5] at com.github.alexthe666.citadel.server.message.PropertiesMessage$Handler.lambda$handle$0(PropertiesMessage.java:50) ~[citadel:1.7.2-1.16.5] at net.minecraftforge.fml.network.NetworkEvent$Context.enqueueWork(NetworkEvent.java:215) ~[forge:?] at com.github.alexthe666.citadel.server.message.PropertiesMessage$Handler.handle(PropertiesMessage.java:48) ~[citadel:1.7.2-1.16.5] at net.minecraftforge.fml.network.simple.IndexedMessageCodec.lambda$tryDecode$3(IndexedMessageCodec.java:128) ~[forge:?] at java.util.Optional.ifPresent(Unknown Source) ~[?:1.8.0_291] at net.minecraftforge.fml.network.simple.IndexedMessageCodec.tryDecode(IndexedMessageCodec.java:128) ~[forge:?] at net.minecraftforge.fml.network.simple.IndexedMessageCodec.consume(IndexedMessageCodec.java:162) ~[forge:?] at net.minecraftforge.fml.network.simple.SimpleChannel.networkEventListener(SimpleChannel.java:80) ~[forge:?] at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) ~[eventbus-4.0.0.jar:?] at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) ~[eventbus-4.0.0.jar:?] at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] at net.minecraftforge.fml.network.NetworkInstance.dispatch(NetworkInstance.java:86) ~[forge:?] at net.minecraftforge.fml.network.NetworkHooks.lambda$onCustomPayload$1(NetworkHooks.java:91) ~[forge:?] at java.util.Optional.map(Unknown Source) ~[?:1.8.0_291] at net.minecraftforge.fml.network.NetworkHooks.onCustomPayload(NetworkHooks.java:91) ~[forge:?] at net.minecraft.client.network.play.ClientPlayNetHandler.func_147240_a(ClientPlayNetHandler.java:1904) ~[?:?] at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:59) ~[?:?] at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:11) ~[?:?] at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?] at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?] at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?] at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:947) ~[?:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] at net.minecraft.client.main.Main.main(Main.java:184) ~[minecraft.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_291] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_291] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_291] at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.1.61.jar:36.1] at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?]

Darkmega18 commented 3 years ago

Everyone. there is a setting in the config for citadel. literally one of two in there. turn off the one related to tracking data for entities and the log spam goes away. although it does have mention of some special things that might break with other Alex mods. but it's better than being spammed and lagged by the spam and seeing nothing else. While we wait for a reply atleast.

TLATER commented 3 years ago

This looks like a duplicate of #40

TLATER commented 3 years ago

I can also confirm that a downgrade, as suggested, fixes the log spam for me. This vaguely makes sense given the changelog.

Whether this results in more memory thrashing than disabling the setting, I'm not sure.

TheWitherlord commented 3 years ago

Getting the same error also, the datatracker is a little funky when Ice and Fire is installed.

Thoddius commented 3 years ago

This is still happening with citadel-1.8.0-1.16.5.jar and alexsmobs-1.12.0.jar, which "-Now requires citadel 1.8.0 or higher". This is causing clients to be kicked from the remote host. Can't downgrade Citadel without also downgrading Alex's Mobs.

Error executing task on Client java.lang.NullPointerException at com.github.alexthe666.citadel.server.entity.datatracker.EntityProperties.getEntity(EntityProperties.java:63) at com.github.alexthe666.iceandfire.entity.props.ChainEntityProperties.loadNBTData(ChainEntityProperties.java:54) at com.github.alexthe666.citadel.server.entity.datatracker.EntityProperties.loadTrackingSensitiveData(EntityProperties.java:112) at com.github.alexthe666.citadel.ClientProxy.handlePropertiesPacket(ClientProxy.java:133) at com.github.alexthe666.citadel.server.message.PropertiesMessage$Handler.lambda$handle$0(PropertiesMessage.java:50) at com.github.alexthe666.citadel.server.message.PropertiesMessage$Handler$$Lambda$25228/1172269408.run(Unknown Source)

aneuhold commented 3 years ago

Everyone. there is a setting in the config for citadel. literally one of two in there. turn off the one related to tracking data for entities and the log spam goes away. although it does have mention of some special things that might break with other Alex mods. but it's better than being spammed and lagged by the spam and seeing nothing else. While we wait for a reply atleast.

This was the answer personally. Thank you!