search

AlexModGuy / LocalLooks

Minecraft Mod that allows players to change appearance in-game
0 stars 2 forks source link

[1.20.1] Skins Only change for client also breakin Playerskins of other Players for said Player #12

Open IvorAmlug opened 9 months ago

IvorAmlug commented 9 months ago

When i change my skin only i see changes everyone else still sees me as my Normal skin. On Top of that only I and any player that used the Mirror to change their skin sees All players as a Broken Steve Texture. While every one else that Reset the skin or never changed it sees the Vanilla ones.

Forge version: 47.2.8 on clients and 47.2.0 ons server Locallooks 1.5-1.20

IvorAmlug commented 9 months ago

Ill try to search my other mods as soon as i have the time and the world backups made

CatAndPaste commented 8 months ago

Can confirm the issue.

NeoForge 47.1.96. Only players who used Magic Mirror to set custom skins can see skins of each other. If player never used the mirror or reseted their skin, they see just normal skins of other players.

Sometimes they appear as Steve/Alex instead of the skins they have on account, but I blame Mojang API for this issue. Happened without Local Looks sometimes before.

CatAndPaste commented 8 months ago

Seems like the problem is caused by AbstractClientPlayerEntityMixin checking tags for localPlayer gotten from Minecraft instance (lines 31 and 41), changing 'Minecraft.getInstance().player' to 'this' fixed error in LAN test with 2 clients.